Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: device/serial/serial_service_unittest.cc

Issue 628873002: replace OVERRIDE and FINAL with override and final in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/test_serial_io_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "device/serial/serial.mojom.h" 8 #include "device/serial/serial.mojom.h"
9 #include "device/serial/serial_service_impl.h" 9 #include "device/serial/serial_service_impl.h"
10 #include "device/serial/test_serial_io_handler.h" 10 #include "device/serial/test_serial_io_handler.h"
11 #include "mojo/public/cpp/bindings/error_handler.h" 11 #include "mojo/public/cpp/bindings/error_handler.h"
12 #include "mojo/public/cpp/bindings/interface_ptr.h" 12 #include "mojo/public/cpp/bindings/interface_ptr.h"
13 #include "mojo/public/cpp/bindings/interface_request.h" 13 #include "mojo/public/cpp/bindings/interface_request.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace device { 16 namespace device {
17 namespace { 17 namespace {
18 18
19 class FakeSerialDeviceEnumerator : public SerialDeviceEnumerator { 19 class FakeSerialDeviceEnumerator : public SerialDeviceEnumerator {
20 virtual mojo::Array<serial::DeviceInfoPtr> GetDevices() OVERRIDE { 20 virtual mojo::Array<serial::DeviceInfoPtr> GetDevices() override {
21 mojo::Array<serial::DeviceInfoPtr> devices(1); 21 mojo::Array<serial::DeviceInfoPtr> devices(1);
22 devices[0] = serial::DeviceInfo::New(); 22 devices[0] = serial::DeviceInfo::New();
23 devices[0]->path = "device"; 23 devices[0]->path = "device";
24 return devices.Pass(); 24 return devices.Pass();
25 } 25 }
26 }; 26 };
27 27
28 class FailToOpenIoHandler : public TestSerialIoHandler { 28 class FailToOpenIoHandler : public TestSerialIoHandler {
29 public: 29 public:
30 virtual void Open(const std::string& port, 30 virtual void Open(const std::string& port,
31 const OpenCompleteCallback& callback) OVERRIDE { 31 const OpenCompleteCallback& callback) override {
32 callback.Run(false); 32 callback.Run(false);
33 } 33 }
34 34
35 protected: 35 protected:
36 virtual ~FailToOpenIoHandler() {} 36 virtual ~FailToOpenIoHandler() {}
37 }; 37 };
38 38
39 } // namespace 39 } // namespace
40 40
41 class SerialServiceTest : public testing::Test, public mojo::ErrorHandler { 41 class SerialServiceTest : public testing::Test, public mojo::ErrorHandler {
42 public: 42 public:
43 SerialServiceTest() : connected_(false), expecting_error_(false) {} 43 SerialServiceTest() : connected_(false), expecting_error_(false) {}
44 44
45 void StoreDevices(mojo::Array<serial::DeviceInfoPtr> devices) { 45 void StoreDevices(mojo::Array<serial::DeviceInfoPtr> devices) {
46 devices_ = devices.Pass(); 46 devices_ = devices.Pass();
47 StopMessageLoop(); 47 StopMessageLoop();
48 } 48 }
49 49
50 virtual void OnConnectionError() OVERRIDE { 50 virtual void OnConnectionError() override {
51 StopMessageLoop(); 51 StopMessageLoop();
52 EXPECT_TRUE(expecting_error_); 52 EXPECT_TRUE(expecting_error_);
53 } 53 }
54 54
55 void RunMessageLoop() { 55 void RunMessageLoop() {
56 run_loop_.reset(new base::RunLoop); 56 run_loop_.reset(new base::RunLoop);
57 run_loop_->Run(); 57 run_loop_->Run();
58 } 58 }
59 59
60 void StopMessageLoop() { 60 void StopMessageLoop() {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 TEST_F(SerialServiceTest, ConnectInvalidPath) { 132 TEST_F(SerialServiceTest, ConnectInvalidPath) {
133 RunConnectTest("invalid_path", false); 133 RunConnectTest("invalid_path", false);
134 } 134 }
135 135
136 TEST_F(SerialServiceTest, ConnectOpenFailed) { 136 TEST_F(SerialServiceTest, ConnectOpenFailed) {
137 io_handler_ = new FailToOpenIoHandler; 137 io_handler_ = new FailToOpenIoHandler;
138 RunConnectTest("device", false); 138 RunConnectTest("device", false);
139 } 139 }
140 140
141 } // namespace device 141 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/test_serial_io_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698