Implement SyncEngine::UpdateRegisteredApps()

Implement SyncEngine::UpdateRegisteredApps()

Test=Automated. Added SyncEngineTest.UpdateRegisteredApps
BUG=240165
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235700

[kinuko, 2013-11-18 08:56:18]

looks good, some nits. Deferring to tzik@ for detailed review

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.h (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.h:122: 
nit: extra empty line

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:47:
virtual void UninstallExtension(std::string extension_id) {
This one's not for TestExtensionService overrides, right?
Can we move this before DisableExtension and remove virtual from them?

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:172:
DLOG(INFO) << origin.spec();
nit: can we reset sync_status to UNKNOWN each time before we call
RegisterOrigin?

[nhiroki, 2013-11-18 09:09:51]

Looks good.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1551: itr !=
app_root_by_app_id_.end(); ++itr) {
indent-nit

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:378: return;
Probably we need to do "continue" here.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:47:
virtual void UninstallExtension(std::string extension_id) {
Can you make |extension_id| const-ref?

[keishi, 2013-11-18 09:15:32]

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1551: itr !=
app_root_by_app_id_.end(); ++itr) {
On 2013/11/18 09:09:52, nhiroki wrote:
> indent-nit

Done.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:378: return;
On 2013/11/18 09:09:52, nhiroki wrote:
> Probably we need to do "continue" here.

Done.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.h (right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.h:122: 
On 2013/11/18 08:56:18, kinuko wrote:
> nit: extra empty line

Done.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc
(right):

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:47:
virtual void UninstallExtension(std::string extension_id) {
On 2013/11/18 08:56:18, kinuko wrote:
> This one's not for TestExtensionService overrides, right?
> Can we move this before DisableExtension and remove virtual from them?

Done.

https://codereview.chromium.org/62883005/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc:172:
DLOG(INFO) << origin.spec();
On 2013/11/18 08:56:18, kinuko wrote:
> nit: can we reset sync_status to UNKNOWN each time before we call
> RegisterOrigin?

Done.

[nhiroki, 2013-11-18 09:19:55]

lgtm!

[tzik, 2013-11-18 09:22:18]

LGTM!

[commit-bot: I haz the power, 2013-11-18 09:22:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/62883005/90001

[commit-bot: I haz the power, 2013-11-18 11:26:00]

Change committed as 235700