Partially convert geolocation IPC to Mojo.

content/browser/geolocation/geolocation_service_context.cc

Index: content/browser/geolocation/geolocation_service_context.cc
diff --git a/content/browser/geolocation/geolocation_service_context.cc b/content/browser/geolocation/geolocation_service_context.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4effa02095498d49e995973f26e03421bd02e8da
--- /dev/null
+++ b/content/browser/geolocation/geolocation_service_context.cc
@@ -0,0 +1,61 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/geolocation/geolocation_service_context.h"
+
+namespace content {
+
+GeolocationServiceContext::GeolocationServiceContext() : paused_(false) {
+}
+
+GeolocationServiceContext::~GeolocationServiceContext() {
+}
+
+void GeolocationServiceContext::CreateService(
+    const base::Closure& update_callback,
+    mojo::InterfaceRequest<GeolocationService> request) {
+  GeolocationServiceImpl* service =
+      new GeolocationServiceImpl(this, update_callback);

[Charlie Reis, 2014/10/21 22:28:32]

Just want to make sure I follow how things work in the Mojo world.  The
GeolocationServiceImpl is specific to a GeolocationDispatcher in the renderer
process, right?

Does the browser process have any way of knowing which process (etc) this is
for?  I'm curious where we can enforce browser process restrictions based on the
process's site (for Site Isolation).  Let's assume for the moment that RPH ID is
sufficient for the check.

[blundell, 2014/10/22 16:05:14]

Yes.
This factory function could take in a RPH ID. When RenderFrameHostImpl adds this
factory function in RFHI::RegisterMojoServices(), it could bind the RPH ID.
Would that cover what you're envisioning?

[Charlie Reis, 2014/10/22 16:11:55]

Yes, I think that would do.  I imagine we'll want that to be a frequent pattern,
so that code in the browser process knows which process it is talking to.

+  if (geoposition_override_)
+    service->SetOverride(*geoposition_override_.get());
+  services_.push_back(service);
+  mojo::WeakBindToRequest(service, &request);
+}
+
+void GeolocationServiceContext::ServiceHadConnectionError(
+    GeolocationServiceImpl* service) {
+  auto it = std::find(services_.begin(), services_.end(), service);
+  DCHECK(it != services_.end());
+  services_.erase(it);
+}
+
+void GeolocationServiceContext::PauseUpdates() {
+  paused_ = true;
+  for (auto* service : services_) {

[Charlie Reis, 2014/10/21 22:28:32]

nit: No braces needed on one line body (here and below).

[blundell, 2014/10/23 12:27:01]

I'd prefer to leave the braces...loops without braces feel alien to me :).

+    service->PauseUpdates();
+  }
+}
+
+void GeolocationServiceContext::ResumeUpdates() {
+  paused_ = false;
+  for (auto* service : services_) {
+    service->ResumeUpdates();
+  }
+}
+
+void GeolocationServiceContext::SetOverride(
+    scoped_ptr<Geoposition> geoposition) {
+  geoposition_override_.swap(geoposition);
+  for (auto* service : services_) {
+    service->SetOverride(*geoposition_override_.get());
+  }
+}
+
+void GeolocationServiceContext::ClearOverride() {
+  for (auto* service : services_) {
+    service->ClearOverride();
+  }
+}
+
+}  // namespace content