Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4574)

Unified Diff: chrome/browser/chromeos/system_logs/command_line_log_source.cc

Issue 628763004: Disable cras_rms from system logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system_logs/command_line_log_source.cc
diff --git a/chrome/browser/chromeos/system_logs/command_line_log_source.cc b/chrome/browser/chromeos/system_logs/command_line_log_source.cc
index eb74def7d702f02f044da643ba76eff464769183..0d8ea6c26dbe56c45ff23f23190f001e869521a8 100644
--- a/chrome/browser/chromeos/system_logs/command_line_log_source.cc
+++ b/chrome/browser/chromeos/system_logs/command_line_log_source.cc
@@ -37,6 +37,10 @@ void ExecuteCommandLines(system_logs::SystemLogsResponse* response) {
command = CommandLine((base::FilePath("/usr/bin/audio_diagnostics")));
commands.push_back(std::make_pair("audio_diagnostics", command));
+#if 0
+ // This command hangs as of R39. TODO(alhli): Make cras_test_client more
+ // robust or add a wrapper script that times out, and fix this or remove
+ // this code. crbug.com/419523
command = CommandLine((base::FilePath("/usr/bin/cras_test_client")));
command.AppendArg("--loopback_file");
command.AppendArg("/dev/null");
@@ -46,6 +50,7 @@ void ExecuteCommandLines(system_logs::SystemLogsResponse* response) {
command.AppendArg("0.01");
command.AppendArg("--show_total_rms");
commands.push_back(std::make_pair("cras_rms", command));
+#endif
command = CommandLine((base::FilePath("/usr/bin/printenv")));
commands.push_back(std::make_pair("env", command));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698