Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 628763003: Support InputRouter recycling (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support InputRouter recycling Allow the InputRouter to be recycled between navigation targets, ensuring input is targetted only to sites for which it was intended. Also remove several unnecessary InputRouterClient methods. BUG=418402

Patch Set 1 #

Patch Set 2 : Updates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -130 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router.h View 2 chunks +11 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 6 chunks +12 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 11 chunks +58 lines, -12 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 10 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 1 4 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 1 2 chunks +6 lines, -16 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/tap_suppression_controller.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 1 3 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/touchpad_tap_suppression_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touchpad_tap_suppression_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 4 chunks +3 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 3 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 4 chunks +20 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/input/input_event_stream_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_stream_validator.cc View 1 chunk +1 line, -1 line 1 comment Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +2 lines, -3 lines 1 comment Download
M content/public/test/test_renderer_host.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jdduke (slow)
6 years ago (2014-12-20 01:12:17 UTC) #1 
https://codereview.chromium.org/628763003/diff/20001/content/common/input/inp...
File content/common/input/input_event_stream_validator.cc (right):

https://codereview.chromium.org/628763003/diff/20001/content/common/input/inp...
content/common/input/input_event_stream_validator.cc:19: :
enabled_(CommandLine::ForCurrentProcess()->HasSwitch(
Hmm, I should probably just get rid of the |enabled_| flag altogether...

https://codereview.chromium.org/628763003/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/628763003/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1269:
private void resetGestureDetection() {
Should probably rename this to |resetInputStream()|.

Powered by Google App Engine
This is Rietveld 408576698