extensions/renderer/resources/serial_service.js - Issue 628763002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/serial_service.js

Issue 628763002: Mojo JS bindings: simplify mojo.connectToService() usage - Part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/data_sender.js ('k') | extensions/test/data/data_receiver_unittest.js » ('j') | mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/serial_service.js

diff --git a/extensions/renderer/resources/serial_service.js b/extensions/renderer/resources/serial_service.js

index 0e0327d83c3207510d3f8d18042b614e2d33ef5d..6a4d4fd0cc6f13acb2f2e8c02661437ab8f7b796 100644

--- a/extensions/renderer/resources/serial_service.js

+++ b/extensions/renderer/resources/serial_service.js

@@ -24,8 +24,9 @@ define('serial_service', [

* Mojo types.

- var service = new serialMojom.SerialServiceProxy(new routerModule.Router(

- serviceProvider.connectToService(serialMojom.SerialServiceProxy.NAME_)));

+ var service = new serialMojom.SerialService.proxyClass(

+ new routerModule.Router(

+ serviceProvider.connectToService(serialMojom.SerialService.name)));

function getDevices() {

return service.getDevices().then(function(response) {

@@ -172,7 +173,7 @@ define('serial_service', [

sendPipe.handle0,

receivePipe.handle0);

var router = new routerModule.Router(pipe.handle1);

- var connection = new serialMojom.ConnectionProxy(router);

+ var connection = new serialMojom.Connection.proxyClass(router);

return connection.getInfo().then(convertServiceInfo).then(function(info) {

return Promise.all([info, allocateConnectionId()]);

}).catch(function(e) {