Skip corrupted png file

Skip corrupted png file
Update directories for resource files

BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243969

[msw, 2013-11-06 21:44:11]

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:24: content/public/android
Perhaps limit this to content/public/android/java/res?

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:29: ui/webui/resources
perhaps limit this to ui/webui/resources/images?

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:276: if [ -f $TMP_DIR/$name -a
$OPTIMIZE_LEVEL != 0 ]; then
Wow, shell scripting is archaic... I need to look up everything.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:297: echo "The png file ($file) may be
corrupted. skipping"
Interesting, have you encountered this case at all?
Does it regularly repro for any of the files in our codebase?

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:476: if [ $CORRUPTED_FILE != 0 ]; then
nit: just print this after everything else outside the if.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:477: echo "Warning: corrupted files found:
$CORRUPTED_FILE"
Would it help to print a list of these file names now, or give the user some
idea of how to handle them?

[oshima, 2014-01-09 19:39:25]

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:24: content/public/android
On 2013/11/06 21:44:12, msw wrote:
> Perhaps limit this to content/public/android/java/res?

Done.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:29: ui/webui/resources
On 2013/11/06 21:44:12, msw wrote:
> perhaps limit this to ui/webui/resources/images?

Done.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:297: echo "The png file ($file) may be
corrupted. skipping"
On 2013/11/06 21:44:12, msw wrote:
> Interesting, have you encountered this case at all?
> Does it regularly repro for any of the files in our codebase?

Yes, I had. I think this happened because someone committed png as text file.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:476: if [ $CORRUPTED_FILE != 0 ]; then
On 2013/11/06 21:44:12, msw wrote:
> nit: just print this after everything else outside the if.

Done.

https://codereview.chromium.org/62873002/diff/30001/tools/resources/optimize-...
tools/resources/optimize-png-files.sh:477: echo "Warning: corrupted files found:
$CORRUPTED_FILE"
On 2013/11/06 21:44:12, msw wrote:
> Would it help to print a list of these file names now, or give the user some
> idea of how to handle them?

File names are printed in #297.

I added "contact author of the CL that landed corrupted files"

[msw, 2014-01-09 20:18:14]

LGTM after you fix the directory path.

https://codereview.chromium.org/62873002/diff/110001/tools/resources/optimize...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/62873002/diff/110001/tools/resources/optimize...
tools/resources/optimize-png-files.sh:24: content/public/android/res
This should be content/public/android/java/res.

[oshima, 2014-01-09 20:33:18]

https://codereview.chromium.org/62873002/diff/110001/tools/resources/optimize...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/62873002/diff/110001/tools/resources/optimize...
tools/resources/optimize-png-files.sh:24: content/public/android/res
On 2014/01/09 20:18:14, msw wrote:
> This should be content/public/android/java/res.

oops, sorry. fixed. thank you for the catch.

[commit-bot: I haz the power, 2014-01-09 20:37:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/62873002/210001

[commit-bot: I haz the power, 2014-01-09 20:42:27]

Change committed as 243969