Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 62863002: Set media_perftests up for android and to be built by the perfbots. (Closed)

Created:
7 years, 1 month ago by rileya (GONE FROM CHROMIUM)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Isaac (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set media_perftests up for android and to be built by the perfbots. BUG=310837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235552

Patch Set 1 #

Total comments: 4

Patch Set 2 : Various changes to make android work properly with the perftests #

Total comments: 1

Patch Set 3 : Add android dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/all_android.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
rileya (GONE FROM CHROMIUM)
https://codereview.chromium.org/62863002/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/62863002/diff/1/build/all_android.gyp#newcode77 build/all_android.gyp:77: '../media/media.gyp:media_perftests_apk', Not quite sure if this is the right ...
7 years, 1 month ago (2013-11-06 19:45:15 UTC) #1
bulach
thanks! drive-by fine by me, but ilevy needs to approve since it changes buildbot loads ...
7 years, 1 month ago (2013-11-07 16:21:34 UTC) #2
rileya (GONE FROM CHROMIUM)
+ilevy https://codereview.chromium.org/62863002/diff/1/build/all_android.gyp File build/all_android.gyp (right): https://codereview.chromium.org/62863002/diff/1/build/all_android.gyp#newcode77 build/all_android.gyp:77: '../media/media.gyp:media_perftests_apk', On 2013/11/07 16:21:34, bulach wrote: > On ...
7 years, 1 month ago (2013-11-07 18:13:33 UTC) #3
rileya (GONE FROM CHROMIUM)
On 2013/11/07 18:13:33, rileya wrote: > +ilevy > > https://codereview.chromium.org/62863002/diff/1/build/all_android.gyp > File build/all_android.gyp (right): > ...
7 years, 1 month ago (2013-11-07 18:29:27 UTC) #4
rileya (GONE FROM CHROMIUM)
On a 2013 Nexus 7, the tests take ~65s to run (80-85s counting test runner ...
7 years, 1 month ago (2013-11-12 23:23:05 UTC) #5
rileya (GONE FROM CHROMIUM)
On 2013/11/12 23:23:05, rileya wrote: > On a 2013 Nexus 7, the tests take ~65s ...
7 years, 1 month ago (2013-11-12 23:27:58 UTC) #6
Isaac (away)
+ android committers with with cool usernames
7 years, 1 month ago (2013-11-13 21:57:05 UTC) #7
cjhopman
lgtm https://codereview.chromium.org/62863002/diff/80001/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/62863002/diff/80001/media/media.gyp#newcode1426 media/media.gyp:1426: 'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)media_perftests<(SHARED_LIB_SUFFIX)', input_shlib_path isn't actually needed (AFAICT).
7 years, 1 month ago (2013-11-14 21:17:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/80001
7 years, 1 month ago (2013-11-14 23:43:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/80001
7 years, 1 month ago (2013-11-15 01:38:52 UTC) #10
scherkus (not reviewing)
lgtm
7 years, 1 month ago (2013-11-15 02:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/80001
7 years, 1 month ago (2013-11-15 03:58:46 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=93027
7 years, 1 month ago (2013-11-15 05:33:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/460001
7 years, 1 month ago (2013-11-15 19:24:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/460001
7 years, 1 month ago (2013-11-15 21:59:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rileya@chromium.org/62863002/460001
7 years, 1 month ago (2013-11-16 00:27:07 UTC) #16
commit-bot: I haz the power
7 years, 1 month ago (2013-11-17 21:20:27 UTC) #17
Message was sent while issue was closed.
Change committed as 235552

Powered by Google App Engine
This is Rietveld 408576698