Issue 6286159: Removing duplicated calls in BrowserView::ProcessTabSelected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6286159: Removing duplicated calls in BrowserView::ProcessTabSelected (Closed)

Created:
9 years, 10 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Removing duplicated calls in BrowserView::ProcessTabSelected 2nd UpdateUIForContents(new_content) UpdateToolbar. BUG=chromium-os:8632 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74174

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_view.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Ben Goodger (Google)

9 years, 10 months ago (2011-02-08 20:28:58 UTC) #3

LGTM too.

On Tue, Feb 8, 2011 at 12:22 PM, <sky@chromium.org> wrote:

> OK
>
> http://codereview.chromium.org/6286159/
>