Add initial code to do filename munging in the FileSystem....

base/file_util_proxy_base.h

Index: base/file_util_proxy_base.h
===================================================================
--- base/file_util_proxy_base.h	(revision 72915)
+++ base/file_util_proxy_base.h	(working copy)
@@ -2,26 +2,21 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef BASE_FILE_UTIL_PROXY_H_
-#define BASE_FILE_UTIL_PROXY_H_
+#ifndef BASE_FILE_UTIL_PROXY_BASE_H_
+#define BASE_FILE_UTIL_PROXY_BASE_H_
 
-#include <vector>
-
 #include "base/callback.h"
 #include "base/file_path.h"
-#include "base/file_util.h"
 #include "base/platform_file.h"
-#include "base/ref_counted.h"
-#include "base/tracked_objects.h"
 
 namespace base {
 
 class MessageLoopProxy;
 class Time;
 
-// This class provides asynchronous access to common file routines.
-class FileUtilProxy {
+class FileUtilProxyBase {

[darin (slow to review), 2011/02/11 18:16:10]

what's the point of this base class?  if the goal is to do file name munging...
couldn't that be better expressed with a filter interface passed to a
FileUtilProxy object?

  public:
+
   // Holds metadata for file or directory entry. Used by ReadDirectoryCallback.
   struct Entry {
     FilePath::StringType name;
@@ -54,60 +49,63 @@
   // If PLATFORM_FILE_CREATE is set in |file_flags| it always tries to create
   // a new file at the given |file_path| and calls back with
   // PLATFORM_FILE_ERROR_FILE_EXISTS if the |file_path| already exists.
-  static bool CreateOrOpen(scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                           const FilePath& file_path,
-                           int file_flags,
-                           CreateOrOpenCallback* callback);
+  virtual bool CreateOrOpen(
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      const FilePath& file_path,
+      int file_flags,
+      CreateOrOpenCallback* callback) = 0;
 
   // Creates a temporary file for writing.  The path and an open file handle
   // are returned.  It is invalid to pass NULL for the callback.
-  static bool CreateTemporary(
+  virtual bool CreateTemporary(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
-      CreateTemporaryCallback* callback);
+      CreateTemporaryCallback* callback) = 0;
 
   // Close the given file handle.
-  static bool Close(scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                    PlatformFile,
-                    StatusCallback* callback);
+  virtual bool Close(
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      PlatformFile,
+      StatusCallback* callback) = 0;
 
-  // Ensures that the given |file_path| exist.  This creates a empty new file
+  // Ensures that the given |file_path| exists.  This creates a empty new file
   // at |file_path| if the |file_path| does not exist.
-  // If a new file han not existed and is created at the |file_path|,
-  // |created| of the callback argument is set true and |error code|
-  // is set PLATFORM_FILE_OK.
-  // If the file already exists, |created| is set false and |error code|
-  // is set PLATFORM_FILE_OK.
-  // If the file hasn't existed but it couldn't be created for some other
-  // reasons, |created| is set false and |error code| indicates the error.
-  static bool EnsureFileExists(
+  // If the file had not existed and is created at the |file_path|,
+  // |created| of the callback argument is set to true and |error code|
+  // is set to PLATFORM_FILE_OK.
+  // If the file already exists, |created| is set to false and |error code|
+  // is set to PLATFORM_FILE_OK.
+  // If the file hadn't existed but it couldn't be created for any reason,
+  // |created| is set to false and |error code| indicates the error.
+  virtual bool EnsureFileExists(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& file_path,
-      EnsureFileExistsCallback* callback);
+      EnsureFileExistsCallback* callback) = 0;
 
   // Retrieves the information about a file. It is invalid to pass NULL for the
   // callback.
-  static bool GetFileInfo(
+  virtual bool GetFileInfo(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& file_path,
-      GetFileInfoCallback* callback);
+      GetFileInfoCallback* callback) = 0;
 
-  static bool GetFileInfoFromPlatformFile(
+  virtual bool GetFileInfoFromPlatformFile(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
-      GetFileInfoCallback* callback);
+      GetFileInfoCallback* callback) = 0;
 
-  static bool ReadDirectory(scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                            const FilePath& file_path,
-                            ReadDirectoryCallback* callback);
+  virtual bool ReadDirectory(
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      const FilePath& file_path,
+      ReadDirectoryCallback* callback) = 0;
 
   // Creates directory at given path. It's an error to create
   // if |exclusive| is true and dir already exists.
-  static bool CreateDirectory(
+  virtual bool CreateDirectory(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& file_path,
       bool exclusive,
       bool recursive,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Copies a file or a directory from |src_file_path| to |dest_file_path|
   // Error cases:
@@ -117,97 +115,99 @@
   // If source file exists but destination path is an existing directory.
   // If source is a parent of destination.
   // If source doesn't exists.
-  static bool Copy(scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                   const FilePath& src_file_path,
-                   const FilePath& dest_file_path,
-                   StatusCallback* callback);
+  virtual bool Copy(
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      const FilePath& src_file_path,
+      const FilePath& dest_file_path,
+      StatusCallback* callback) = 0;
 
   // Moves a file or a directory from src_file_path to dest_file_path.
   // Error cases are similar to Copy method's error cases.
-  static bool Move(
+  virtual bool Move(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& src_file_path,
       const FilePath& dest_file_path,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Deletes a file or a directory.
   // It is an error to delete a non-empty directory with recursive=false.
-  static bool Delete(scoped_refptr<MessageLoopProxy> message_loop_proxy,
-                     const FilePath& file_path,
-                     bool recursive,
-                     StatusCallback* callback);
+  virtual bool Delete(
+      scoped_refptr<MessageLoopProxy> message_loop_proxy,
+      const FilePath& file_path,
+      bool recursive,
+      StatusCallback* callback) = 0;
 
   // Deletes a directory and all of its contents.
-  static bool RecursiveDelete(
+  virtual bool RecursiveDelete(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& file_path,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Reads from a file. On success, the file pointer is moved to position
   // |offset + bytes_to_read| in the file. The callback can be NULL.
-  static bool Read(
+  virtual bool Read(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
       int64 offset,
       char* buffer,
       int bytes_to_read,
-      ReadWriteCallback* callback);
+      ReadWriteCallback* callback) = 0;
 
   // Writes to a file. If |offset| is greater than the length of the file,
   // |false| is returned. On success, the file pointer is moved to position
   // |offset + bytes_to_write| in the file. The callback can be NULL.
-  static bool Write(
+  virtual bool Write(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
       int64 offset,
       const char* buffer,
       int bytes_to_write,
-      ReadWriteCallback* callback);
+      ReadWriteCallback* callback) = 0;
 
   // Touches a file. The callback can be NULL.
-  static bool Touch(
+  virtual bool Touch(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
       const Time& last_access_time,
       const Time& last_modified_time,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Touches a file. The callback can be NULL.
-  static bool Touch(
+  virtual bool Touch(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& file_path,
       const Time& last_access_time,
       const Time& last_modified_time,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Truncates a file to the given length. If |length| is greater than the
   // current length of the file, the file will be extended with zeroes.
   // The callback can be NULL.
-  static bool Truncate(
+  virtual bool Truncate(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
       int64 length,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Truncates a file to the given length. If |length| is greater than the
   // current length of the file, the file will be extended with zeroes.
   // The callback can be NULL.
-  static bool Truncate(
+  virtual bool Truncate(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       const FilePath& path,
       int64 length,
-      StatusCallback* callback);
+      StatusCallback* callback) = 0;
 
   // Flushes a file. The callback can be NULL.
-  static bool Flush(
+  virtual bool Flush(
       scoped_refptr<MessageLoopProxy> message_loop_proxy,
       PlatformFile file,
-      StatusCallback* callback);
-
- private:
-  DISALLOW_IMPLICIT_CONSTRUCTORS(FileUtilProxy);
+      StatusCallback* callback) = 0;
+ protected:
+  FileUtilProxyBase() {}
+  DISALLOW_COPY_AND_ASSIGN(FileUtilProxyBase);
 };
 
 }  // namespace base
 
-#endif  // BASE_FILE_UTIL_PROXY_H_
+#endif  // BASE_FILE_UTIL_PROXY_BASE_H_