Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: webkit/fileapi/file_system_path_manager_unittest.cc

Issue 6286038: Add initial code to do filename munging in the FileSystem.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_path_manager_unittest.cc
===================================================================
--- webkit/fileapi/file_system_path_manager_unittest.cc (revision 74905)
+++ webkit/fileapi/file_system_path_manager_unittest.cc (working copy)
@@ -202,9 +202,10 @@
return root_path_callback_status_;
}
+ // TODO(ericu): Add a test for the new parameter.
bool CheckValidFileSystemPath(FileSystemPathManager* manager,
const FilePath& path) {
- return manager->CrackFileSystemPath(path, NULL, NULL, NULL);
+ return manager->CrackFileSystemPath(path, NULL, NULL, NULL, NULL);
}
FilePath data_path() { return data_dir_->path(); }
@@ -355,7 +356,7 @@
kPathToVirtualPathTestCases[i]);
FilePath virtual_path;
EXPECT_TRUE(manager->CrackFileSystemPath(absolute_path, NULL, NULL,
- &virtual_path));
+ NULL, &virtual_path));
FilePath test_case_path;
test_case_path = test_case_path.AppendASCII(
@@ -374,14 +375,14 @@
fileapi::kFileSystemTypeTemporary,
true /* create */, &root_path));
FilePath path = root_path.AppendASCII("test");
- EXPECT_TRUE(manager->CrackFileSystemPath(path, NULL, &type, NULL));
+ EXPECT_TRUE(manager->CrackFileSystemPath(path, NULL, &type, NULL, NULL));
EXPECT_EQ(fileapi::kFileSystemTypeTemporary, type);
EXPECT_TRUE(GetRootPath(manager.get(), GURL("http://foo.com/"),
fileapi::kFileSystemTypePersistent,
true /* create */, &root_path));
path = root_path.AppendASCII("test");
- EXPECT_TRUE(manager->CrackFileSystemPath(path, NULL, &type, NULL));
+ EXPECT_TRUE(manager->CrackFileSystemPath(path, NULL, &type, NULL, NULL));
EXPECT_EQ(fileapi::kFileSystemTypePersistent, type);
}

Powered by Google App Engine
This is Rietveld 408576698