chrome/browser/resources/options/pref_ui.js - Issue 6285003: DOMUI: Use dispatchSimpleEvent instead of programatically clicking the checkbox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 6285003: DOMUI: Use dispatchSimpleEvent instead of programatically clicking the checkbox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/pref_ui.js

diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js

index b6f495c0809f5a4867655ba942efbfc18f0286b6..99db29866c73b97d0cbe4cca9c12b843b6e83228 100644

--- a/chrome/browser/resources/options/pref_ui.js

+++ b/chrome/browser/resources/options/pref_ui.js

@@ -50,7 +50,7 @@ cr.define('options', function() {

// Listen to user events.

this.addEventListener(

- 'click',

+ 'change',

function(e) {

var value = self.inverted_pref ? !self.checked : self.checked;

switch(self.valueType) {

@@ -72,7 +72,7 @@ cr.define('options', function() {

initializeValueType: function(valueType) {

this.valueType = valueType || 'boolean';

- }

+ },

};

/**

« chrome/browser/resources/options/personal_options.js ('K') | « chrome/browser/resources/options/personal_options.js ('k') | no next file » | no next file with comments »