Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 62843007: Remove implementation of Entity constructor (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove implementation of Entity constructor Remove implementation of Entity constructor as we never construct Entity objects. This will lead in a link time error if someone tries to use it instead of a runtime error (due to the ASSERT_NOT_REACHED() in the constructor). This gets rid of a case where 0 is passed as TreeScope to the ContainerNode / Node constructor. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/core/dom/Entity.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 1 month ago (2013-11-14 16:02:16 UTC) #1
eseidel
I'm confused. Why do we even have this if we can't construct one? Is this ...
7 years, 1 month ago (2013-11-14 16:15:56 UTC) #2
Inactive
On 2013/11/14 16:15:56, eseidel wrote: > I'm confused. Why do we even have this if ...
7 years, 1 month ago (2013-11-14 17:15:18 UTC) #3
eseidel
lgtm I suspect we can go further... but OK.
7 years, 1 month ago (2013-11-14 17:30:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/62843007/1
7 years, 1 month ago (2013-11-14 17:32:12 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 19:01:29 UTC) #6
Message was sent while issue was closed.
Change committed as 162041

Powered by Google App Engine
This is Rietveld 408576698