media/cast/test/crypto_utility.h - Issue 62843002: Cast: Added support for AES-CTR crypto.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/cast/test/crypto_utility.h

Issue 62843002: Cast: Added support for AES-CTR crypto. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/cast/rtp_common/mock_rtp_payload_feedback.h"	5 // Utility functions for crypto testing.

	6

	7 #include "media/cast/cast_config.h"

6	8

7 namespace media {	9 namespace media {

8 namespace cast {	10 namespace cast {

9	11

10 MockRtpPayloadFeedback::MockRtpPayloadFeedback() {	12 // Convert to a binary string from a base 16 string.

11 }	13 std::string ConvertFromBase16String(const std::string base_16);
	wtc 2013/11/13 20:57:17 Nit: Base16String => HexString? IMPORTANT: this f Nit: Base16String => HexString? IMPORTANT: this function may not be necessary. You should be able to use base::HexStringToBytes. #include "base/strings/string_number_conversions.h" BASE_EXPORT bool HexStringToBytes(const std::string& input, std::vector<uint8>* output); The only problem is that base::HexStringToBytes uses std::vector<uint8> as the output. If you need to use std::string, ConvertFromBase16String can simply call base::HexStringToBytes and convert std::vector<uint8> to std::string. You can find sample code here: https://codereview.chromium.org/54043003/diff/370001/net/quic/test_tools/quic... pwestin 2013/11/15 19:38:17 Done. Show quoted text On 2013/11/13 20:57:17, wtc wrote: > > Nit: Base16String => HexString? > > IMPORTANT: this function may not be necessary. You should be able to use > base::HexStringToBytes. > > #include "base/strings/string_number_conversions.h" > > BASE_EXPORT bool HexStringToBytes(const std::string& input, > std::vector<uint8>* output); > > The only problem is that base::HexStringToBytes uses std::vector<uint8> as the > output. If you need to use std::string, ConvertFromBase16String can simply call > base::HexStringToBytes and convert std::vector<uint8> to std::string. You can > find sample code here: > > https://codereview.chromium.org/54043003/diff/370001/net/quic/test_tools/quic... Done.
12

13 MockRtpPayloadFeedback::~MockRtpPayloadFeedback() {

14 }

15	14

16 } // namespace cast	15 } // namespace cast

17 } // namespace media	16 } // namespace media

	17

OLD	NEW

« media/cast/cast_defines.h ('K') | « media/cast/rtp_sender/rtp_packetizer/rtp_packetizer.cc ('k') | media/cast/test/crypto_utility.cc » ('j') | media/cast/test/crypto_utility.cc » ('J')