Modify dartanalyzer scripts to look more like dart2js scripts.

tools/testing/dart/compiler_configuration.dart

Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 20ab1c77163774da2d5fa9021a06c82e0e88c58b..c9e5af179ae948e6bb33854f0cb0a3fa7ac00c85 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -391,5 +391,22 @@ class DartBasedAnalyzerCompilerConfiguration
           'dart2analyzer', isDebug: isDebug, isChecked: isChecked,
           isHostChecked: isHostChecked, useSdk: useSdk);
 
-  String computeCompilerPath(String buildDir) => 'editor/tools/analyzer';
+  String computeCompilerPath(String buildDir) {
+    var prefix = 'sdk/bin';
+    String suffix = executableScriptSuffix;
+    if (isHostChecked) {
+      // The script dartanalyzer_developer is not included in the
+      // shipped SDK, that is the script is not installed in
+      // "$buildDir/dart-sdk/bin/"
+      // TODO(paulberry): the script dartanalyzer_developer currently
+      // points to the wrong place (the Java-based analyzer).  Once
+      // this is fixed, we should run dartanalyzer_developer when in
+      // isHostChecked mode.
+      // return '$prefix/dartanalyzer_developer$suffix';

[ricow1, 2014/10/07 06:03:08]

No commented out code please

Additionally, for when you actually do add the code here, I would throw an error
if you run with usesdk and isHostChecked

[Paul Berry, 2014/10/07 23:39:17]

Done.

+    }
+    if (useSdk) {
+      prefix = '$buildDir/dart-sdk/bin';
+    }
+    return '$prefix/dartanalyzer$suffix';
+  }
 }