Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 628363002: Modify dartanalyzer scripts to look more like dart2js scripts. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address code review comments and rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/bin/dartanalyzer.bat ('K') | « tools/create_sdk.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 97822270347298282589cd67037d80b95a2c60e2..b33f5549cfde0a91a3af01e900e259ca826e304a 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -392,5 +392,24 @@ class DartBasedAnalyzerCompilerConfiguration
'dart2analyzer', isDebug: isDebug, isChecked: isChecked,
isHostChecked: isHostChecked, useSdk: useSdk);
- String computeCompilerPath(String buildDir) => 'editor/tools/analyzer';
+ String computeCompilerPath(String buildDir) {
+ var prefix = 'sdk/bin';
+ String suffix = executableScriptSuffix;
+ if (isHostChecked) {
+ if (useSdk) {
+ throw "--host-checked and --use-sdk cannot be used together";
+ }
+ // The script dartanalyzer_developer is not included in the
+ // shipped SDK, that is the script is not installed in
+ // "$buildDir/dart-sdk/bin/"
+ // TODO(paulberry): the script dartanalyzer_developer currently
+ // points to the wrong place (the Java-based analyzer). Once
+ // this is fixed, we should run dartanalyzer_developer when in
+ // isHostChecked mode.
+ }
+ if (useSdk) {
+ prefix = '$buildDir/dart-sdk/bin';
+ }
+ return '$prefix/dartanalyzer$suffix';
+ }
}
« sdk/bin/dartanalyzer.bat ('K') | « tools/create_sdk.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698