Modify dartanalyzer scripts to look more like dart2js scripts.

tools/testing/dart/compiler_configuration.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library compiler_configuration;
 
 import 'dart:io' show
     Platform;
 
 import 'runtime_configuration.dart' show
@@ skipping 373 matching lines @@
     extends AnalyzerCompilerConfiguration {
   DartBasedAnalyzerCompilerConfiguration({
       bool isDebug,
       bool isChecked,
       bool isHostChecked,
       bool useSdk})
       : super(
           'dart2analyzer', isDebug: isDebug, isChecked: isChecked,
           isHostChecked: isHostChecked, useSdk: useSdk);
 
-  String computeCompilerPath(String buildDir) => 'editor/tools/analyzer';
+  String computeCompilerPath(String buildDir) {
+    var prefix = 'sdk/bin';
+    String suffix = executableScriptSuffix;
+    if (isHostChecked) {
+      // The script dartanalyzer_developer is not included in the
+      // shipped SDK, that is the script is not installed in
+      // "$buildDir/dart-sdk/bin/"
+      // TODO(paulberry): the script dartanalyzer_developer currently
+      // points to the wrong place (the Java-based analyzer).  Once
+      // this is fixed, we should run dartanalyzer_developer when in
+      // isHostChecked mode.  Additionally, we should throw an error
+      // if both useSdk and isHostChecked are true.

[ahe, 2014/10/15 08:44:54]

Report an error?

[ricow1, 2014/10/15 11:12:34]

+, just do it instead of the comment - it will be shorter anyway

[Paul Berry, 2014/10/16 00:16:03]

Done.

+    }
+    if (useSdk) {
+      prefix = '$buildDir/dart-sdk/bin';
+    }
+    return '$prefix/dartanalyzer$suffix';
+  }
 }