Issue 62833010: Reland "Add a full screen virtual keyboard to virtual keyboard root window"

Issue 62833010: Reland "Add a full screen virtual keyboard to virtual keyboard root window" (Closed)

Created:
7 years, 1 month ago by bshe

Modified:
7 years, 1 month ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a full screen virtual keyboard to virtual keyboard root window This relands https://codereview.chromium.org/47873003. It was reverted because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest test crash on win8_aura. R=oshima@chromium.org TBR=jamescook, sadrul BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235795

Patch Set 1 #

Patch Set 2 : fix win8_aura #

Patch Set 3 : format nit. The main change is patchset 2 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -116 lines)			Patch
M	ash/ash.gyp	View		4 chunks	+5 lines, -2 lines	0 comments	Download
M	ash/display/display_controller.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/display/virtual_keyboard_window_controller.h	View		3 chunks	+16 lines, -0 lines	0 comments	Download
M	ash/display/virtual_keyboard_window_controller.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
A	ash/display/virtual_keyboard_window_controller_unittest.cc	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
D	ash/keyboard_controller_proxy_stub.h	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	ash/keyboard_controller_proxy_stub.cc	View		1 chunk	+0 lines, -35 lines	0 comments	Download
M	ash/root_window_controller.cc	View		4 chunks	+17 lines, -10 lines	0 comments	Download
M	ash/root_window_controller_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/shell.h	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	ash/shell.cc	View		6 chunks	+22 lines, -9 lines	0 comments	Download
A +	ash/shell/keyboard_controller_proxy_stub.h	View		2 chunks	+12 lines, -6 lines	0 comments	Download
A +	ash/shell/keyboard_controller_proxy_stub.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	ash/shell/shell_delegate_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/test_shell_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	ui/keyboard/keyboard_controller.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	ui/keyboard/keyboard_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/keyboard/keyboard_switches.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/keyboard/keyboard_switches.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/keyboard/keyboard_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/keyboard/keyboard_util.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bshe

Hi Oshima. Would you mind to take a look at this simple fix for win8_aura ...

7 years, 1 month ago (2013-11-18 19:02:02 UTC) #1

bshe

7 years, 1 month ago (2013-11-18 19:33:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r235795 (presubmit successful).

Expand Messages | Collapse Messages