Add chromium_code to tracing.gyp to build with warnings.

Add chromium_code to tracing.gyp to build with warnings.

Also remove the defines! section which seems unnecessary (as far as I
can tell none of the code impacted includes anything from //content).

Both of these are per suggestion from thakis@.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237563

[Nico, 2013-11-18 13:51:15]

Thank you!

lgtm


On Mon, Nov 18, 2013 at 1:25 PM, <joi@chromium.org> wrote:

> Reviewers: jbauman,
>
> Description:
> Add chromium_code to tracing.gyp to build with warnings.
>
> Also remove the defines! section which seems unnecessary (as far as I
> can tell none of the code impacted includes anything from //content).
>
> Both of these are per suggestion from thakis@.
>
> BUG=none
>
> Please review this at https://codereview.chromium.org/62833009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -1 lines):
>   M components/tracing.gyp
>
>
> Index: components/tracing.gyp
> diff --git a/components/tracing.gyp b/components/tracing.gyp
> index fe7e588f3ff65327e8202241c70b6fc5e288135e..
> 4f8a796c7ad6d258ca4a1852c07ac9a5cf39b68c 100644
> --- a/components/tracing.gyp
> +++ b/components/tracing.gyp
> @@ -8,11 +8,13 @@
>  # on this, thus if you try to rename this to gypi and include it in
>  # components.gyp, you will get a circular dependency error.
>  {
> +  'variables': {
> +    'chromium_code': 1,
> +  },
>    'targets' : [
>      {
>        'target_name': 'tracing',
>        'type': 'static_library',
> -      'defines!': ['CONTENT_IMPLEMENTATION'],
>        'dependencies': [
>          '../base/base.gyp:base',
>          '../ipc/ipc.gyp:ipc',
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jói, 2013-11-19 12:10:31]

jbauman: Gentle ping.

On Mon, Nov 18, 2013 at 2:51 PM, Nico Weber <thakis@chromium.org> wrote:
> Thank you!
>
> lgtm
>
>
> On Mon, Nov 18, 2013 at 1:25 PM, <joi@chromium.org> wrote:
>>
>> Reviewers: jbauman,
>>
>> Description:
>> Add chromium_code to tracing.gyp to build with warnings.
>>
>> Also remove the defines! section which seems unnecessary (as far as I
>> can tell none of the code impacted includes anything from //content).
>>
>> Both of these are per suggestion from thakis@.
>>
>> BUG=none
>>
>> Please review this at https://codereview.chromium.org/62833009/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+3, -1 lines):
>>   M components/tracing.gyp
>>
>>
>> Index: components/tracing.gyp
>> diff --git a/components/tracing.gyp b/components/tracing.gyp
>> index
>>
fe7e588f3ff65327e8202241c70b6fc5e288135e..4f8a796c7ad6d258ca4a1852c07ac9a5cf39b68c
>> 100644
>> --- a/components/tracing.gyp
>> +++ b/components/tracing.gyp
>> @@ -8,11 +8,13 @@
>>  # on this, thus if you try to rename this to gypi and include it in
>>  # components.gyp, you will get a circular dependency error.
>>  {
>> +  'variables': {
>> +    'chromium_code': 1,
>> +  },
>>    'targets' : [
>>      {
>>        'target_name': 'tracing',
>>        'type': 'static_library',
>> -      'defines!': ['CONTENT_IMPLEMENTATION'],
>>        'dependencies': [
>>          '../base/base.gyp:base',
>>          '../ipc/ipc.gyp:ipc',
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jói, 2013-11-20 20:40:47]

nduca@, are you around and could you review this?

On Tue, Nov 19, 2013 at 1:09 PM, Jói Sigurðsson <joi@chromium.org> wrote:
> jbauman: Gentle ping.
>
> On Mon, Nov 18, 2013 at 2:51 PM, Nico Weber <thakis@chromium.org> wrote:
>> Thank you!
>>
>> lgtm
>>
>>
>> On Mon, Nov 18, 2013 at 1:25 PM, <joi@chromium.org> wrote:
>>>
>>> Reviewers: jbauman,
>>>
>>> Description:
>>> Add chromium_code to tracing.gyp to build with warnings.
>>>
>>> Also remove the defines! section which seems unnecessary (as far as I
>>> can tell none of the code impacted includes anything from //content).
>>>
>>> Both of these are per suggestion from thakis@.
>>>
>>> BUG=none
>>>
>>> Please review this at https://codereview.chromium.org/62833009/
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>>
>>> Affected files (+3, -1 lines):
>>>   M components/tracing.gyp
>>>
>>>
>>> Index: components/tracing.gyp
>>> diff --git a/components/tracing.gyp b/components/tracing.gyp
>>> index
>>>
fe7e588f3ff65327e8202241c70b6fc5e288135e..4f8a796c7ad6d258ca4a1852c07ac9a5cf39b68c
>>> 100644
>>> --- a/components/tracing.gyp
>>> +++ b/components/tracing.gyp
>>> @@ -8,11 +8,13 @@
>>>  # on this, thus if you try to rename this to gypi and include it in
>>>  # components.gyp, you will get a circular dependency error.
>>>  {
>>> +  'variables': {
>>> +    'chromium_code': 1,
>>> +  },
>>>    'targets' : [
>>>      {
>>>        'target_name': 'tracing',
>>>        'type': 'static_library',
>>> -      'defines!': ['CONTENT_IMPLEMENTATION'],
>>>        'dependencies': [
>>>          '../base/base.gyp:base',
>>>          '../ipc/ipc.gyp:ipc',
>>>
>>>
>>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jói, 2013-11-26 14:18:00]

nduca, jbauman: Ping, it's been 8 days and this is a very small change.

On Wed, Nov 20, 2013 at 8:40 PM, Jói Sigurðsson <joi@chromium.org> wrote:
> nduca@, are you around and could you review this?
>
> On Tue, Nov 19, 2013 at 1:09 PM, Jói Sigurðsson <joi@chromium.org> wrote:
>> jbauman: Gentle ping.
>>
>> On Mon, Nov 18, 2013 at 2:51 PM, Nico Weber <thakis@chromium.org> wrote:
>>> Thank you!
>>>
>>> lgtm
>>>
>>>
>>> On Mon, Nov 18, 2013 at 1:25 PM, <joi@chromium.org> wrote:
>>>>
>>>> Reviewers: jbauman,
>>>>
>>>> Description:
>>>> Add chromium_code to tracing.gyp to build with warnings.
>>>>
>>>> Also remove the defines! section which seems unnecessary (as far as I
>>>> can tell none of the code impacted includes anything from //content).
>>>>
>>>> Both of these are per suggestion from thakis@.
>>>>
>>>> BUG=none
>>>>
>>>> Please review this at https://codereview.chromium.org/62833009/
>>>>
>>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>>>
>>>> Affected files (+3, -1 lines):
>>>>   M components/tracing.gyp
>>>>
>>>>
>>>> Index: components/tracing.gyp
>>>> diff --git a/components/tracing.gyp b/components/tracing.gyp
>>>> index
>>>>
fe7e588f3ff65327e8202241c70b6fc5e288135e..4f8a796c7ad6d258ca4a1852c07ac9a5cf39b68c
>>>> 100644
>>>> --- a/components/tracing.gyp
>>>> +++ b/components/tracing.gyp
>>>> @@ -8,11 +8,13 @@
>>>>  # on this, thus if you try to rename this to gypi and include it in
>>>>  # components.gyp, you will get a circular dependency error.
>>>>  {
>>>> +  'variables': {
>>>> +    'chromium_code': 1,
>>>> +  },
>>>>    'targets' : [
>>>>      {
>>>>        'target_name': 'tracing',
>>>>        'type': 'static_library',
>>>> -      'defines!': ['CONTENT_IMPLEMENTATION'],
>>>>        'dependencies': [
>>>>          '../base/base.gyp:base',
>>>>          '../ipc/ipc.gyp:ipc',
>>>>
>>>>
>>>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nduca, 2013-11-26 18:20:51]

sorry! lgtm.

[commit-bot: I haz the power, 2013-11-27 10:16:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/62833009/1

[commit-bot: I haz the power, 2013-11-27 13:38:43]

Change committed as 237563