Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 62833005: The WebVTT parsing algorithm allows empty cue text (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

The WebVTT parsing algorithm allows empty cue text Adjust tests: tc027-empty-cue - PASS -> FAIL, because opposite assumptions opera/track/webvtt/parsing:newlines.vtt - one more cue (empty) observed opera/interfaces/TextTrackCue/text.html - FAIL -> PASS (The newlines.vtt file is truncated compared to the original/upstream version, so chose to update the expected result rather than modifying the test. Aim to update the testfile at a later point.) BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161924

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M LayoutTests/media/track/opera/interfaces/TextTrackCue/text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 chunk +1 line, -1 line 2 comments Download
M LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
fs
7 years, 1 month ago (2013-11-08 17:34:13 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt File LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt (right): https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt#newcode33 LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt:33: FAIL WebVTT parser tests, newlines.vtt assert_equals: number of cues ...
7 years, 1 month ago (2013-11-11 12:27:27 UTC) #2
fs
On 2013/11/11 12:27:27, jochen wrote: > https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt > File LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt > (right): > > https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt#newcode33 ...
7 years, 1 month ago (2013-11-11 12:53:51 UTC) #3
jochen (gone - plz use gerrit)
lgtm can you mention this in the CL description please?
7 years, 1 month ago (2013-11-11 12:54:46 UTC) #4
fs
On 2013/11/11 12:54:46, jochen wrote: > lgtm > > can you mention this in the ...
7 years, 1 month ago (2013-11-11 13:09:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/62833005/1
7 years, 1 month ago (2013-11-11 13:09:53 UTC) #6
philipj_slow
https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt File LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt (right): https://codereview.chromium.org/62833005/diff/1/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt#newcode33 LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt:33: FAIL WebVTT parser tests, newlines.vtt assert_equals: number of cues ...
7 years, 1 month ago (2013-11-13 14:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/62833005/1
7 years, 1 month ago (2013-11-13 14:21:14 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 15:45:49 UTC) #9
Message was sent while issue was closed.
Change committed as 161924

Powered by Google App Engine
This is Rietveld 408576698