pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart - Issue 628293004: Remove references to Engine classes from protocol.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

Issue 628293004: Remove references to Engine classes from protocol.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename_local.dart ('k') | pkg/analysis_server/test/computer/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

index 5744fb24f48b0fa3eba17a410b5c731e3a42368c..81a69bd551274da74c3a4c7566b6e34d2934d193 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart

@@ -6,7 +6,8 @@ library services.src.refactoring.rename_unit_member;

import 'dart:async';

-import 'package:analysis_server/src/protocol.dart' show Location, SourceChange;

+import 'package:analysis_server/src/protocol_server.dart' show

+ newLocation_fromElement, newLocation_fromMatch;

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/correction/util.dart';

import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';

@@ -200,7 +201,7 @@ class _RenameUnitMemberValidator {

getElementKindName(element),

getElementKindName(shadow),

getElementQualifiedName(shadow));

- result.addError(message, new Location.fromElement(shadow));

+ result.addError(message, newLocation_fromElement(shadow));

}

});

}

@@ -219,7 +220,7 @@ class _RenameUnitMemberValidator {

"Library already declares {0} with name '{1}'.",

getElementKindName(element),

name);

- result.addError(message, new Location.fromElement(element));

+ result.addError(message, newLocation_fromElement(element));

}

});

}

@@ -257,7 +258,7 @@ class _RenameUnitMemberValidator {

elementKind.displayName,

getElementKindName(member),

getElementQualifiedName(member));

- result.addError(message, new Location.fromMatch(memberReference));

+ result.addError(message, newLocation_fromMatch(memberReference));

}

});