pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart - Issue 628293004: Remove references to Engine classes from protocol.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 628293004: Remove references to Engine classes from protocol.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_computer.dart ('k') | pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

index b664d7bad081d7bc0e531262a943b1e8589a28ed..a95f5eaefde3fafe6054ad7725ef962dd99ead54 100644

--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

@@ -4,8 +4,8 @@

library services.completion.suggestion.builder;

-import 'package:analysis_server/src/protocol.dart' as protocol show Element, ElementKind;

-import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;

+import 'package:analysis_server/src/protocol_server.dart' as protocol;

+import 'package:analysis_server/src/protocol_server.dart' hide Element, ElementKind;

import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';

import 'package:analyzer/src/generated/element.dart';

@@ -96,7 +96,7 @@ class ClassElementSuggestionBuilder extends GeneralizingElementVisitor {

element.isDeprecated,

false);

- suggestion.element = new protocol.Element.fromEngine(element);

+ suggestion.element = newElement_fromEngine(element);

if (suggestion.element != null) {

if (element is FieldElement) {

suggestion.element.kind = protocol.ElementKind.GETTER;

@@ -167,7 +167,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor {

String completion = element.name;

if (completion != null && completion.length > 0) {

CompletionSuggestion suggestion = new CompletionSuggestion(

- new CompletionSuggestionKind.fromElementKind(element.kind),

+ protocol.newCompletionSuggestionKind_fromElementKind(element.kind),

CompletionRelevance.DEFAULT,

completion,

completion.length,

@@ -175,7 +175,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor {

element.isDeprecated,

false);

- suggestion.element = new protocol.Element.fromEngine(element);

+ suggestion.element = newElement_fromEngine(element);

request.suggestions.add(suggestion);

}