Issue 628223002: Reland: Add a use counter for Intl.v8BreakIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 628223002: Reland: Add a use counter for Intl.v8BreakIterator (Closed)

Created:
6 years, 2 months ago by Erik Corry Chromium.org

Modified:
6 years, 2 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Reland: Add a use counter for Intl.v8BreakIterator This relands https://codereview.chromium.org/619913002/ The test has been fixed to do a GC so it does not appear to leak in ASAN. In addition the test has been fixed to work in the no-i18n build, by incorporating the change from https://codereview.chromium.org/631743002/ R=ishell@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24423

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/i18n.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Erik Corry Chromium.org

6 years, 2 months ago (2014-10-06 15:50:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24423 (presubmit successful).