Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 628213003: Replace OVERRIDE and FINAL with override and final in content/browser/web_contents (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/browser/web_contents BUG=417463 Committed: https://crrev.com/120b0b00eab41393387ab2e9cb612955be3843f2 Cr-Commit-Position: refs/heads/master@{#298488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -520 lines) Patch
M content/browser/web_contents/aura/gesture_nav_simple.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.h View 1 chunk +15 lines, -15 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/aura/window_slider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/aura/window_slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/web_contents/opened_by_dom_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +22 lines, -22 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 6 chunks +249 lines, -249 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 2 chunks +25 lines, -25 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +52 lines, -52 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +27 lines, -27 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
PTAL
6 years, 2 months ago (2014-10-07 06:15:36 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 14:24:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628213003/1
6 years, 2 months ago (2014-10-07 14:40:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6091e5150f48d19dbaa7d69a4176f163b1a56de7
6 years, 2 months ago (2014-10-07 15:49:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 15:50:48 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/120b0b00eab41393387ab2e9cb612955be3843f2
Cr-Commit-Position: refs/heads/master@{#298488}

Powered by Google App Engine
This is Rietveld 408576698