Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5304)

Unified Diff: chrome/browser/signin/easy_unlock_service.cc

Issue 628193003: [Easy Unlock] Update handling of the trial easy unlock/signin run (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: autoshow tooltip for hardlock Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/easy_unlock_service.cc
diff --git a/chrome/browser/signin/easy_unlock_service.cc b/chrome/browser/signin/easy_unlock_service.cc
index e4408a1b471359dfe37029a2440dafcdd41b02ff..dac35ce23728dec58a59b1f866a8a62585b99f99 100644
--- a/chrome/browser/signin/easy_unlock_service.cc
+++ b/chrome/browser/signin/easy_unlock_service.cc
@@ -171,10 +171,6 @@ void EasyUnlockService::RegisterProfilePrefs(
prefs::kEasyUnlockEnabled,
false,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- registry->RegisterBooleanPref(
- prefs::kEasyUnlockShowTutorial,
- true,
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
registry->RegisterDictionaryPref(
prefs::kEasyUnlockPairing,
new base::DictionaryValue(),
@@ -191,7 +187,7 @@ void EasyUnlockService::RegisterPrefs(PrefRegistrySimple* registry) {
}
// static
-void EasyUnlockService::RemoveHardlockStateForUser(const std::string& user_id) {
+void EasyUnlockService::ResetLocalStateForUser(const std::string& user_id) {
DCHECK(!user_id.empty());
PrefService* local_state = GetLocalState();
@@ -263,7 +259,6 @@ EasyUnlockScreenlockStateHandler*
screenlock_state_handler_.reset(new EasyUnlockScreenlockStateHandler(
GetUserEmail(),
GetHardlockState(),
- GetType() == TYPE_REGULAR ? profile_->GetPrefs() : NULL,
ScreenlockBridge::Get()));
}
return screenlock_state_handler_.get();
@@ -344,6 +339,14 @@ void EasyUnlockService::CheckCryptohomeKeysAndMaybeHardlock() {
#endif
}
+void EasyUnlockService::SetTrialRun() {
+ DCHECK(GetType() == TYPE_REGULAR);
+
+ EasyUnlockScreenlockStateHandler* handler = GetScreenlockStateHandler();
+ if (handler)
+ handler->SetTrialRun();
+}
+
void EasyUnlockService::AddObserver(EasyUnlockServiceObserver* observer) {
observers_.AddObserver(observer);
}
@@ -539,7 +542,8 @@ void EasyUnlockService::OnCryptohomeKeysFetchedForChecking(
for (const auto& device_key_data : key_data_list)
devices_in_cryptohome.insert(device_key_data.public_key);
- if (paired_devices != devices_in_cryptohome) {
+ if (paired_devices != devices_in_cryptohome ||
+ GetHardlockState() == EasyUnlockScreenlockStateHandler::NO_PAIRING) {
xiyuan 2014/10/09 21:03:55 Why do we need to map NO_PAIRING to PAIRING_CHANGE
SetHardlockStateForUser(user_id,
EasyUnlockScreenlockStateHandler::PAIRING_CHANGED);
}

Powered by Google App Engine
This is Rietveld 408576698