Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 628153004: Add MinidumpContextWriter test (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpContextWriter test. TEST=minidump_test MinidumpContextWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e74a272ab50f7af0fa58e9a3d4657cd9bd3ef799

Patch Set 1 #

Patch Set 2 : Don’t use using directives (“using namespace”) in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -0 lines) Patch
M minidump/minidump.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A minidump/minidump_context_test_util.h View 1 chunk +61 lines, -0 lines 0 comments Download
A minidump/minidump_context_test_util.cc View 1 chunk +319 lines, -0 lines 0 comments Download
A minidump/minidump_context_writer_test.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
I thought that we wouldn’t wind up doing this, because it would all just be ...
6 years, 2 months ago (2014-10-07 04:27:34 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-07 21:10:02 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-07 21:27:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e74a272ab50f7af0fa58e9a3d4657cd9bd3ef799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698