Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 628133003: Use View Holder pattern in AccountsAdapter.getView(). (Closed)

Created:
6 years, 2 months ago by Sungmann Cho
Modified:
6 years, 2 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use View Holder pattern in AccountsAdapter.getView(). Currently, the lint warns at: AccountsAdapter.java:29 Unconditional layout inflation from view adapter: Should use View Holder pattern (use recycled view passed into this method as the second parameter) for smoother scrolling: ViewHolder [warning] This CL fixes the above lint error. BUG=327768 Committed: https://crrev.com/bdafed7f77d2b14fc5ea76a755c0f8818877cddd Cr-Commit-Position: refs/heads/master@{#299406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/android/java/src/org/chromium/chromoting/AccountsAdapter.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 2 months ago (2014-10-06 13:03:50 UTC) #2
Sungmann Cho
ping...
6 years, 2 months ago (2014-10-10 01:09:50 UTC) #3
garykac
lgtm
6 years, 2 months ago (2014-10-14 00:15:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628133003/1
6 years, 2 months ago (2014-10-14 00:18:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 00:39:26 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:40:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdafed7f77d2b14fc5ea76a755c0f8818877cddd
Cr-Commit-Position: refs/heads/master@{#299406}

Powered by Google App Engine
This is Rietveld 408576698