Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 628133002: Replacing the OVERRIDE with override and FINAL with final in /src/printing (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in /src/printing This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/263c31370ed81377b59ed58b9ae41ded18630c13 Cr-Commit-Position: refs/heads/master@{#298414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -107 lines) Patch
M printing/emf_win.h View 1 chunk +13 lines, -13 lines 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/metafile.h View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +14 lines, -14 lines 0 comments Download
M printing/printing_context_android.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/printing_context_linux.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/printing_context_mac.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/printing_context_system_dialog_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +12 lines, -12 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 09:31:03 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-10-06 18:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628133002/1
6 years, 2 months ago (2014-10-06 18:28:32 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 01:42:51 UTC) #7
anujsharma
On 2014/10/07 01:42:51, I haz the power (commit-bot) wrote: > Exceeded time limit waiting for ...
6 years, 2 months ago (2014-10-07 02:35:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628133002/1
6 years, 2 months ago (2014-10-07 07:28:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8345da6a482f0702a827c8b4dc549a39fd4c0c17
6 years, 2 months ago (2014-10-07 07:29:50 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 07:30:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/263c31370ed81377b59ed58b9ae41ded18630c13
Cr-Commit-Position: refs/heads/master@{#298414}

Powered by Google App Engine
This is Rietveld 408576698