Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 628083002: Replacing the OVERRIDE with override and FINAL with final in chrome/service (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in chrome/service This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/0da06d0ec798825e71e6da277a22e5121a91ab2b Cr-Commit-Position: refs/heads/master@{#298562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -130 lines) Patch
M chrome/service/cloud_print/cloud_print_auth.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_wipeout.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 9 chunks +32 lines, -32 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_ipc_server.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/service_process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 07:18:08 UTC) #2
MRV
On 2014/10/06 07:18:08, MRV wrote: > PTAL Dear Mr.Vitaly Buka PTAL
6 years, 2 months ago (2014-10-06 16:15:32 UTC) #3
MRV
Dear Mr.Vitaly Buka please review my patch.
6 years, 2 months ago (2014-10-07 17:29:16 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-10-07 17:53:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628083002/1
6 years, 2 months ago (2014-10-07 17:54:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5c4860782ee5e3e72e76383a8396f5414f9d3ee1
6 years, 2 months ago (2014-10-07 20:36:33 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 20:37:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0da06d0ec798825e71e6da277a22e5121a91ab2b
Cr-Commit-Position: refs/heads/master@{#298562}

Powered by Google App Engine
This is Rietveld 408576698