Oilpan: fix (MSVC) build after r183241.

Oilpan: fix (MSVC) build after r183241.

Rename WebFrame::isAlive(Visitor*, WebFrame*) to isFrameAlive(). Using
isAlive() is problematic wrt IsGarbageCollectedMixin<T>, which
syntactically probes for isAlive().

(MSVC is more eager about template instantiation and the probing for the
private WebFrame::isAlive() method is disallowed.)

R=haraken,tkent
BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183247

[sof, 2014-10-06 07:02:56]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2014-10-06 07:02:56]

Please take a look.

[haraken, 2014-10-06 07:05:08]

LGTM

[tkent, 2014-10-06 07:06:40]

lgtm.

We may rename GarbageCollectedIMixin::isAlive instead.  It's a very generic
name.

[tkent, 2014-10-06 07:06:46]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[haraken, 2014-10-06 07:09:38]

> We may rename GarbageCollectedIMixin::isAlive instead.  It's a very generic
> name.

Agreed.

[sof, 2014-10-06 07:14:32]

On 2014/10/06 07:06:40, tkent wrote:
> lgtm.
> 
> We may rename GarbageCollectedIMixin::isAlive instead.  It's a very generic
> name.

Yes, that isAlive() is only used internally (afaik) so we have some extra
degrees of freedom.

[sof, 2014-10-06 07:20:22]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-10-06 07:20:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/628063003/1

[commit-bot: I haz the power, 2014-10-06 07:21:05]

Committed patchset #1 (id:1) as 183247

[sof, 2014-10-06 08:46:29]

On 2014/10/06 07:14:32, sof wrote:
> On 2014/10/06 07:06:40, tkent wrote:
> > lgtm.
> > 
> > We may rename GarbageCollectedIMixin::isAlive instead.  It's a very generic
> > name.
> 
> Yes, that isAlive() is only used internally (afaik) so we have some extra
> degrees of freedom.

Should we want to do that, https://codereview.chromium.org/633463002/

[Renaming this particular WebFrame helper makes sense regardless, i think.
Naming now being similar to traceFrame().]