Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 62803008: Bugfix: make dependent code field in AllocationSite weak. (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Bugfix: dependent code field in AllocationSite was keeping code objects alive even after context death. BUG=320532 LOG=Y R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17856

Patch Set 1 #

Patch Set 2 : Fixed an issue with walking the weak list of allocation sites. #

Patch Set 3 : Additional fixes. #

Patch Set 4 : Added test #

Patch Set 5 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -19 lines) Patch
M src/heap.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-visiting.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting-inl.h View 1 2 2 chunks +26 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-320532.js View 1 2 3 4 1 chunk +12 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Ulan, PTAL, thx. --Michael
7 years, 1 month ago (2013-11-18 16:04:20 UTC) #1
ulan
LGTM
7 years, 1 month ago (2013-11-19 10:05:44 UTC) #2
mvstanton
7 years, 1 month ago (2013-11-19 10:17:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r17856.

Powered by Google App Engine
This is Rietveld 408576698