|
|
Allow printing component to be removed completely
Using enable_printing=0 removes all of the source files of the printing
component, but has no effect on its dependencies. It is wrong to empty out the
target inside the target. If printing is disabled, then the dependency on
printing.gyp is not needed and can be removed.
This target was causing libgcrypt to be linked even when printing was disabled.
That problem goes away with this change.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233563
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+65 lines, -23 lines) |
Patch |
 |
M |
build/all.gyp
|
View
|
1
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome.gyp
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_chromeos.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_ui.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_common.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_dll.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_renderer.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
1
|
4 chunks |
+10 lines, -2 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/service.gyp
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
content/content_browser.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
printing/printing.gyp
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
webkit/glue/webkit_glue.gypi
|
View
|
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|
Chromium Code Reviews
Issue
62793002:
Allow printing component to be removed completely (Closed)
