Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 627873002: Fix the GN rule of yasm for ChromeOS. (Closed)

Created:
4 years, 11 months ago by Jun Mukai
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the GN rule of yasm for ChromeOS. ChromeOS needs to run as linux here. BUG=None R=cmasone@chromium.org, hclam@chromium.org TEST=manually Committed: https://crrev.com/a59ce187e29beb8883ed211028f72557c7e4541b Cr-Commit-Position: refs/heads/master@{#298149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/yasm/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
4 years, 11 months ago (2014-10-04 00:28:20 UTC) #1
Alpha Left Google
lgtm
4 years, 11 months ago (2014-10-04 00:29:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627873002/1
4 years, 11 months ago (2014-10-04 00:33:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3d279f5544457e0d946e73c10fa8dea0dc26e6b7
4 years, 11 months ago (2014-10-04 01:15:54 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2014-10-04 01:16:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a59ce187e29beb8883ed211028f72557c7e4541b
Cr-Commit-Position: refs/heads/master@{#298149}

Powered by Google App Engine
This is Rietveld 408576698