Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 627763002: Add new 'typ' python testing framework to third_party/. (Closed)

Created:
6 years, 2 months ago by Dirk Pranke
Modified:
5 years ago
CC:
chromium-reviews, open-source-third-party-reviews_google.com, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add new 'typ' python testing framework to third_party/. This change adds a new python testing framework that will replace the various adhoc variants of this we use in Chromium and Blink, at least temporarily until if/when we can switch to infra's expect_tests framework. Using this library will allow us to consolidate a bunch of duplicated code used for telemetry_unittests, webkit_python_tests, mojo_python_tests, webkit_tests, and elsewhere. TBR=cpu@chromium.org, dtu@chromium.org BUG=402172 Committed: https://crrev.com/4e9ea61141ef60036c65190cb8cefb92a5e7aa7d Cr-Commit-Position: refs/heads/master@{#299004}

Patch Set 1 #

Patch Set 2 : export TestInput from the api, fix args #

Patch Set 3 : update w/ latest typ, update README.chromium #

Patch Set 4 : upload to typ v0.8.1, update README.chromium #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4957 lines, --4 lines) Patch
A third_party/typ/LICENSE View 1 chunk +201 lines, -0 lines 0 comments Download
A third_party/typ/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/typ/README.chromium View 1 2 3 1 chunk +32 lines, -0 lines 2 comments Download
A third_party/typ/README.rst View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/typ/pylintrc View 1 chunk +274 lines, -0 lines 0 comments Download
A third_party/typ/run View 1 2 3 1 chunk +149 lines, -0 lines 0 comments Download
A third_party/typ/setup.cfg View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/typ/setup.py View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/typ/tools/__init__.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/typ/tools/cov.py View 1 2 3 1 chunk +137 lines, -0 lines 0 comments Download
A third_party/typ/typ/__init__.py View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
A third_party/typ/typ/__main__.py View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/typ/typ/arg_parser.py View 1 2 3 1 chunk +264 lines, -0 lines 0 comments Download
A third_party/typ/typ/cmdline.py View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/typ/typ/fakes/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/typ/typ/fakes/host_fake.py View 1 2 3 1 chunk +298 lines, -0 lines 0 comments Download
A third_party/typ/typ/fakes/test_result_server_fake.py View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/typ/typ/fakes/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/typ/typ/fakes/tests/host_fake_test.py View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/typ/typ/fakes/tests/test_result_server_fake_test.py View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/typ/typ/fakes/unittest_fakes.py View 1 2 3 1 chunk +176 lines, -0 lines 0 comments Download
A third_party/typ/typ/host.py View 1 2 3 1 chunk +282 lines, -0 lines 0 comments Download
A third_party/typ/typ/json_results.py View 1 2 3 1 chunk +186 lines, -0 lines 0 comments Download
A third_party/typ/typ/pool.py View 1 2 3 1 chunk +176 lines, -0 lines 0 comments Download
A third_party/typ/typ/printer.py View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/typ/typ/runner.py View 1 2 3 1 chunk +790 lines, -0 lines 0 comments Download
A third_party/typ/typ/stats.py View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/typ/typ/test_case.py View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/typ/typ/tests/arg_parser_test.py View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/host_test.py View 1 2 3 1 chunk +161 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/json_results_test.py View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/main_test.py View 1 2 3 1 chunk +717 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/pool_test.py View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/printer_test.py View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/stats_test.py View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/typ/typ/tests/test_case_test.py View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/typ/typ/version.py View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
Dirk Pranke
6 years, 2 months ago (2014-10-03 18:53:17 UTC) #1
Dirk Pranke
Carlos, can I get an OWNERS approval for this? Apparently Brett doesn't feel like it ...
6 years, 2 months ago (2014-10-03 21:15:46 UTC) #3
Dirk Pranke
(feel like being an OWNER, that is).
6 years, 2 months ago (2014-10-03 21:16:03 UTC) #4
cpu_(ooo_6.6-7.5)
I'll be your operator for this trip, please follow: http://www.chromium.org/developers/adding-3rd-party-libraries
6 years, 2 months ago (2014-10-06 19:50:24 UTC) #5
cpu_(ooo_6.6-7.5)
feel free to skip the security review but definitely do the open-source-third-party-reviews@google.com part.
6 years, 2 months ago (2014-10-06 19:51:37 UTC) #6
Dirk Pranke
Hi Danny, Max, Can I get OSPO approval to add this as a third-party lib ...
6 years, 2 months ago (2014-10-06 20:42:08 UTC) #8
chromium-reviews
Yar I'll review now. On Mon, Oct 6, 2014 at 1:42 PM, <dpranke@chromium.org> wrote: > ...
6 years, 2 months ago (2014-10-06 20:44:27 UTC) #9
chromium-reviews
LGTM On Mon, Oct 6, 2014 at 1:44 PM, Max Sills <xam@google.com> wrote: > Yar ...
6 years, 2 months ago (2014-10-06 20:45:13 UTC) #10
Dirk Pranke
On 2014/10/06 20:45:13, chromium-reviews wrote: > LGTM Thanks! Carlos, does this look good to you?
6 years, 2 months ago (2014-10-06 21:05:08 UTC) #11
Dirk Pranke
updated to typ v0.8.1; this should now be ready for landing.
6 years, 2 months ago (2014-10-09 21:14:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627763002/60001
6 years, 2 months ago (2014-10-09 21:16:44 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-09 23:11:50 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4e9ea61141ef60036c65190cb8cefb92a5e7aa7d Cr-Commit-Position: refs/heads/master@{#299004}
6 years, 2 months ago (2014-10-09 23:12:54 UTC) #16
tfarina
https://codereview.chromium.org/627763002/diff/60001/third_party/typ/README.chromium File third_party/typ/README.chromium (right): https://codereview.chromium.org/627763002/diff/60001/third_party/typ/README.chromium#newcode27 third_party/typ/README.chromium:27: cp typ/OWNERS typ_new Dirk, is "OWNERS" right here? I'm ...
5 years ago (2015-12-12 01:06:09 UTC) #17
tfarina
5 years ago (2015-12-12 01:17:38 UTC) #18
Message was sent while issue was closed.
https://codereview.chromium.org/627763002/diff/60001/third_party/typ/README.c...
File third_party/typ/README.chromium (right):

https://codereview.chromium.org/627763002/diff/60001/third_party/typ/README.c...
third_party/typ/README.chromium:27: cp typ/OWNERS typ_new
On 2015/12/12 01:06:09, tfarina wrote:
> Dirk, is "OWNERS" right here? I'm just curious, because I was searching for
> instructions on how to update a project we check-in in the chromium tree for
> updating re2 and came to this. I would think it is 'cp typ/ typ_new/' or
> something.

Oh, actually, this is just copying the OWNERS file that is already in the
chromium tree to the 'new' .git tree. OK, now that I follow, makes sense. Sorry
for the noise!

Powered by Google App Engine
This is Rietveld 408576698