Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: mojo/common/handle_watcher_unittest.cc

Issue 62773003: Mojo: Add BindingsSupportImpl on top of HandleWatcher (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/common/handle_watcher.h" 5 #include "mojo/common/handle_watcher.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/test/simple_test_tick_clock.h" 10 #include "base/test/simple_test_tick_clock.h"
(...skipping 14 matching lines...) Expand all
25 uint32_t num_handles = 0; 25 uint32_t num_handles = 0;
26 return MojoReadMessage(handle, NULL, &num_bytes, NULL, &num_handles, 26 return MojoReadMessage(handle, NULL, &num_bytes, NULL, &num_handles,
27 MOJO_READ_MESSAGE_FLAG_MAY_DISCARD); 27 MOJO_READ_MESSAGE_FLAG_MAY_DISCARD);
28 } 28 }
29 29
30 void RunUntilIdle() { 30 void RunUntilIdle() {
31 base::RunLoop run_loop; 31 base::RunLoop run_loop;
32 run_loop.RunUntilIdle(); 32 run_loop.RunUntilIdle();
33 } 33 }
34 34
35 void DeleteWatcherAndForwardResult(
36 HandleWatcher* watcher,
37 base::Callback<void(MojoResult)> next_callback,
38 MojoResult result) {
39 delete watcher;
40 next_callback.Run(result);
41 }
42
35 // Helper class to manage the callback and running the message loop waiting for 43 // Helper class to manage the callback and running the message loop waiting for
36 // message to be received. Typical usage is something like: 44 // message to be received. Typical usage is something like:
37 // Schedule callback returned from GetCallback(). 45 // Schedule callback returned from GetCallback().
38 // RunUntilGotCallback(); 46 // RunUntilGotCallback();
39 // EXPECT_TRUE(got_callback()); 47 // EXPECT_TRUE(got_callback());
40 // clear_callback(); 48 // clear_callback();
41 class CallbackHelper { 49 class CallbackHelper {
42 public: 50 public:
43 CallbackHelper() 51 CallbackHelper()
44 : got_callback_(false), 52 : got_callback_(false),
45 run_loop_(NULL), 53 run_loop_(NULL),
46 weak_factory_(this) {} 54 weak_factory_(this) {}
47 ~CallbackHelper() {} 55 ~CallbackHelper() {}
48 56
49 // See description above |got_callback_|. 57 // See description above |got_callback_|.
50 bool got_callback() const { return got_callback_; } 58 bool got_callback() const { return got_callback_; }
51 void clear_callback() { got_callback_ = false; } 59 void clear_callback() { got_callback_ = false; }
52 60
53 // Runs the current MessageLoop until the callback returned from GetCallback() 61 // Runs the current MessageLoop until the callback returned from GetCallback()
54 // is notified. 62 // is notified.
55 void RunUntilGotCallback() { 63 void RunUntilGotCallback() {
56 ASSERT_TRUE(run_loop_ == NULL); 64 ASSERT_TRUE(run_loop_ == NULL);
57 base::RunLoop run_loop; 65 base::RunLoop run_loop;
58 base::AutoReset<base::RunLoop*> reseter(&run_loop_, &run_loop); 66 base::AutoReset<base::RunLoop*> reseter(&run_loop_, &run_loop);
59 run_loop.Run(); 67 run_loop.Run();
60 } 68 }
61 69
62 base::Closure GetCallback() { 70 base::Callback<void(MojoResult)> GetCallback() {
63 return base::Bind(&CallbackHelper::OnCallback, weak_factory_.GetWeakPtr()); 71 return base::Bind(&CallbackHelper::OnCallback, weak_factory_.GetWeakPtr());
64 } 72 }
65 73
66 void Start(HandleWatcher* watcher, MojoHandle handle) { 74 void Start(HandleWatcher* watcher, MojoHandle handle) {
75 StartWithCallback(watcher, handle, GetCallback());
76 }
77
78 void StartWithCallback(HandleWatcher* watcher, MojoHandle handle,
79 const base::Callback<void(MojoResult)>& callback) {
67 watcher->Start(handle, MOJO_WAIT_FLAG_READABLE, MOJO_DEADLINE_INDEFINITE, 80 watcher->Start(handle, MOJO_WAIT_FLAG_READABLE, MOJO_DEADLINE_INDEFINITE,
68 GetCallback()); 81 callback);
69 } 82 }
70 83
71 private: 84 private:
72 void OnCallback() { 85 void OnCallback(MojoResult result) {
73 got_callback_ = true; 86 got_callback_ = true;
74 if (run_loop_) 87 if (run_loop_)
75 run_loop_->Quit(); 88 run_loop_->Quit();
76 } 89 }
77 90
78 // Set to true when the callback is called. 91 // Set to true when the callback is called.
79 bool got_callback_; 92 bool got_callback_;
80 93
81 // If non-NULL we're in RunUntilGotCallback(). 94 // If non-NULL we're in RunUntilGotCallback().
82 base::RunLoop* run_loop_; 95 base::RunLoop* run_loop_;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 281
269 HandleWatcher watcher3; 282 HandleWatcher watcher3;
270 callback_helper3.Start(&watcher3, test_pipe3.handle_0()); 283 callback_helper3.Start(&watcher3, test_pipe3.handle_0());
271 284
272 callback_helper2.RunUntilGotCallback(); 285 callback_helper2.RunUntilGotCallback();
273 EXPECT_FALSE(callback_helper1.got_callback()); 286 EXPECT_FALSE(callback_helper1.got_callback());
274 EXPECT_TRUE(callback_helper2.got_callback()); 287 EXPECT_TRUE(callback_helper2.got_callback());
275 EXPECT_FALSE(callback_helper3.got_callback()); 288 EXPECT_FALSE(callback_helper3.got_callback());
276 } 289 }
277 290
291 TEST_F(HandleWatcherTest, DeleteInCallback) {
292 ScopedMessagePipe test_pipe;
293 CallbackHelper callback_helper;
294
295 HandleWatcher* watcher = new HandleWatcher();
296 callback_helper.StartWithCallback(watcher, test_pipe.handle_1(),
297 base::Bind(&DeleteWatcherAndForwardResult,
298 watcher,
299 callback_helper.GetCallback()));
300 WriteToHandle(test_pipe.handle_0());
301 callback_helper.RunUntilGotCallback();
302 EXPECT_TRUE(callback_helper.got_callback());
303 }
304
278 } // namespace test 305 } // namespace test
279 } // namespace common 306 } // namespace common
280 } // namespace mojo 307 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698