chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 62763003: Leave fullscreen mode in an app window when ESC key is pressed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 62763003: Leave fullscreen mode in an app window when ESC key is pressed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_interactive_uitest.cc ('K') | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index ef790797307a4355710a6c0056d37b52980ac1df..e9b66494f0dd5334059438018d612dc9ac28d130 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -352,6 +352,7 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{ APIPermission::kFullscreen, "fullscreen" },

{ APIPermission::kAudio, "audio" },

{ APIPermission::kWebRtc, "webrtc" },

+ { APIPermission::kOverrideEscFullscreen, "overrideEscFullscreen" },

// Settings override permissions.

{ APIPermission::kHomepage, "homepage",