Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: apps/shell_window.cc

Issue 62763003: Leave fullscreen mode in an app window when ESC key is pressed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: apps/shell_window.cc
diff --git a/apps/shell_window.cc b/apps/shell_window.cc
index 5e4098f504d51f62a3971a450f99b155572babed..dafa327d0e12c4844cfcbfac7c0964e040e0b66b 100644
--- a/apps/shell_window.cc
+++ b/apps/shell_window.cc
@@ -283,9 +283,39 @@ void ShellWindow::AddNewContents(WebContents* source,
initial_pos, user_gesture, was_blocked);
}
+bool ShellWindow::PreHandleKeyboardEvent(
+ content::WebContents* source,
+ const content::NativeWebKeyboardEvent& event,
+ bool* is_keyboard_shortcut) {
+ // Here, we can handle a key event before the content gets it. When we are
+ // fullscreen, we want to allow the user to leave when ESC is pressed.
+ // However, if the application has the "overrideEscFullscreen" permission, we
+ // should let it override that behavior.
+ // ::HandleKeyboardEvent() will only be called if the KeyEvent's default
+ // action is not prevented.
+ // Thus, we should handle the KeyEvent here only if the permission is not set.
+ if (event.windowsKeyCode == ui::VKEY_ESCAPE &&
+ (fullscreen_for_tab_ || fullscreen_for_window_api_) &&
+ !extension_->HasAPIPermission(APIPermission::kOverrideEscFullscreen)) {
+ Restore();
+ return true;
+ }
+
+ return false;
+}
+
void ShellWindow::HandleKeyboardEvent(
WebContents* source,
const content::NativeWebKeyboardEvent& event) {
+ // If the window is currently fullscreen, ESC should leave fullscreen.
+ // If this code is being called for ESC, that means that the KeyEvent's
+ // default behavior was not prevented by the content.
+ if (event.windowsKeyCode == ui::VKEY_ESCAPE &&
+ (fullscreen_for_tab_ || fullscreen_for_window_api_)) {
+ Restore();
+ return;
+ }
+
native_app_window_->HandleKeyboardEvent(event);
}

Powered by Google App Engine
This is Rietveld 408576698