Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 627603002: Handle dl role for browsertests (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle dl role for browsertests This patch enables AccessibilitDl test and adds the case for dl role in browsertests on Mac and Android. BUG=226505 R=dmazzoni@chromium.org, aboxhall@chromium.org Committed: https://crrev.com/4c5b538078c55a046de21033e3fef61cfa4e7aa2 Cr-Commit-Position: refs/heads/master@{#298013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +4 lines, -9 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
je_julie(Not used)
Dominic, PTAL.
6 years, 2 months ago (2014-10-03 05:23:18 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-03 05:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627603002/1
6 years, 2 months ago (2014-10-03 07:42:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 558f3937f0696879ca8ba61a5e072fd0dfa7bb85
6 years, 2 months ago (2014-10-03 08:35:08 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 08:35:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c5b538078c55a046de21033e3fef61cfa4e7aa2
Cr-Commit-Position: refs/heads/master@{#298013}

Powered by Google App Engine
This is Rietveld 408576698