Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3230)

Unified Diff: chrome/browser/supervised_user/supervised_user_service.cc

Issue 627593003: Adding infrastructure for possibility of changing manager names for the supervised accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_service.cc
diff --git a/chrome/browser/supervised_user/supervised_user_service.cc b/chrome/browser/supervised_user/supervised_user_service.cc
index 0ce61d9b7103276d47b63fd1f4ee4a83eed14e43..94ea5291afca9a782bc8129981a85da959b6a16a 100644
--- a/chrome/browser/supervised_user/supervised_user_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_service.cc
@@ -281,28 +281,31 @@ void SupervisedUserService::GetCategoryNames(CategoryList* list) {
}
std::string SupervisedUserService::GetCustodianEmailAddress() const {
+ std::string custodian_email = profile_->GetPrefs()->GetString(
+ prefs::kSupervisedUserCustodianEmail);
#if defined(OS_CHROMEOS)
- return chromeos::ChromeUserManager::Get()
- ->GetSupervisedUserManager()
- ->GetManagerDisplayEmail(
- user_manager::UserManager::Get()->GetActiveUser()->email());
-#else
- return profile_->GetPrefs()->GetString(prefs::kSupervisedUserCustodianEmail);
+ if (custodian_email.empty()) {
+ custodian_email = chromeos::ChromeUserManager::Get()
+ ->GetSupervisedUserManager()
+ ->GetManagerDisplayEmail(
+ user_manager::UserManager::Get()->GetActiveUser()->email());
+ }
#endif
+ return custodian_email;
}
std::string SupervisedUserService::GetCustodianName() const {
-#if defined(OS_CHROMEOS)
- return base::UTF16ToUTF8(
- chromeos::ChromeUserManager::Get()
- ->GetSupervisedUserManager()
- ->GetManagerDisplayName(
- user_manager::UserManager::Get()->GetActiveUser()->email()));
-#else
std::string name = profile_->GetPrefs()->GetString(
prefs::kSupervisedUserCustodianName);
- return name.empty() ? GetCustodianEmailAddress() : name;
+#if defined(OS_CHROMEOS)
+ if (name.empty()) {
+ name = base::UTF16ToUTF8(chromeos::ChromeUserManager::Get()
+ ->GetSupervisedUserManager()
+ ->GetManagerDisplayName(
+ user_manager::UserManager::Get()->GetActiveUser()->email()));
+ }
#endif
+ return name = name.empty() ? GetCustodianEmailAddress() : name;
Marc Treib 2014/10/06 07:40:19 nit: Remove "name = "
merkulova 2014/10/06 15:37:25 Done.
}
void SupervisedUserService::AddNavigationBlockedCallback(

Powered by Google App Engine
This is Rietveld 408576698