Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 627593002: ServiceWorker: Retrieve performance information from TRACE_EVENTs of SW (Closed)

Created:
6 years, 2 months ago by shimazu
Modified:
6 years, 2 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Retrieve performance information from TRACE_EVENTs of SW This patch will work after https://codereview.chromium.org/620553012/ is landed. BUG=372759 TEST=./tools/perf/run_benchmark --browser=android-chrome-shell service_worker.service_worker This must be executed after commenting out '@benchmark.Disabled' in tools/perf/benchmarks/service_worker.py. Committed: https://crrev.com/cd8689abcf174326eeb0a107ac9b53bcc48b86bd Cr-Commit-Position: refs/heads/master@{#299427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
shimazu
Could you review this patch?
6 years, 2 months ago (2014-10-03 05:29:59 UTC) #2
dtu
lgtm
6 years, 2 months ago (2014-10-14 00:13:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627593002/1
6 years, 2 months ago (2014-10-14 01:02:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62801)
6 years, 2 months ago (2014-10-14 01:53:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627593002/1
6 years, 2 months ago (2014-10-14 01:56:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62801)
6 years, 2 months ago (2014-10-14 02:04:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627593002/1
6 years, 2 months ago (2014-10-14 03:11:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 03:52:10 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:53:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd8689abcf174326eeb0a107ac9b53bcc48b86bd
Cr-Commit-Position: refs/heads/master@{#299427}

Powered by Google App Engine
This is Rietveld 408576698