Enable passing cast channel certificate authority keys.

extensions/browser/api/cast_channel/cast_channel_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/cast_channel/cast_channel_api.h"
 
 #include <limits>
 #include <string>
 
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/time/default_tick_clock.h"
 #include "base/values.h"
 #include "content/public/browser/browser_thread.h"
+#include "extensions/browser/api/cast_channel/cast_auth_util.h"
 #include "extensions/browser/api/cast_channel/cast_socket.h"
 #include "extensions/browser/api/cast_channel/logger.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/common/api/cast_channel/logging.pb.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "url/gurl.h"
 
 // Default timeout interval for connection setup.
@@ skipping 476 matching lines @@
     SetResult(new base::BinaryValue(out.Pass(), length));
   } else {
     SetError("Unable to get logs.");
   }
 
   api_->GetLogger()->Reset();
 
   AsyncWorkCompleted();
 }
 
+CastChannelSetAuthorityKeysFunction::CastChannelSetAuthorityKeysFunction() {
+}
+
+CastChannelSetAuthorityKeysFunction::~CastChannelSetAuthorityKeysFunction() {
+}
+
+bool CastChannelSetAuthorityKeysFunction::Prepare() {
+  params_ = cast_channel::SetAuthorityKeys::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(params_.get());
+  return true;
+}
+
+void CastChannelSetAuthorityKeysFunction::AsyncWorkStart() {
+  std::string& signature = params_->signature;
+  std::string& keys = params_->keys;
+  if (cast_channel::SetTrustedCertificateAuthorities(signature, keys)) {

[mark a. foltz, 2014/10/09 17:57:20]

|signature| and |keys| should be sanity checked and an error returned on invalid
data.  For example |signature| should be a deterministic size and keys.size()
should be > 0 and < some reasonably large maximum.  I worry about attempts to
overflow the crypto routines.

[vadimgo, 2014/10/09 23:31:55]

Added checks here and in SetTrustedCertificateAuthorities.
On 2014/10/09 17:57:20, mark a. foltz wrote:

+    SetResult(new base::StringValue(""));  // Intentionally returns a blank.

[mark a. foltz, 2014/10/09 17:57:20]

Can this just fire an empty callback?

[vadimgo, 2014/10/09 23:31:55]

I couldn't figure out how to do it, it seems to require a value.
On 2014/10/09 17:57:20, mark a. foltz wrote:

+  } else {
+    SetError("Unable to set authority keys.");
+  }
+
+  AsyncWorkCompleted();
+}
+
 }  // namespace extensions