Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 627563002: Mojo JS standalone app launches files specified with mojo_shell command-line args (Closed)

Created:
6 years, 2 months ago by hansmuller
Modified:
6 years, 2 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo JS standalone app launches files specified with mojo_shell command-line args Arguments specified with the mojo_js_standalone app URL are loaded and run. Each argument is run on a separate thread, in its own V8 isolate. For example: mojo_shell 'mojo:mojo_js_standalone foo.js bar.js' Also: moved the one-time gin V8 initialization from JSApp - where it could be called from multiple threads - to ApplicationDelegateImpl::Initialize(). Where it's called once, before any JSApp's are started. BUG=419906 Committed: https://crrev.com/17d76b85d2e3939c428bfbfa2edce4bdcfd3be90 Cr-Commit-Position: refs/heads/master@{#298032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M mojo/apps/js/application_delegate_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/apps/js/js_app.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/apps/js/standalone_main.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hansmuller
This is a tiny change that uses the command-line argument feature I added in https://codereview.chromium.org/617943002 ...
6 years, 2 months ago (2014-10-03 00:27:02 UTC) #2
Aaron Boodman
LGTM, thanks.
6 years, 2 months ago (2014-10-03 02:30:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627563002/1
6 years, 2 months ago (2014-10-03 14:25:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e0cd4c302bb1533da4519d6aeb27c6988116756c
6 years, 2 months ago (2014-10-03 15:00:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 15:00:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17d76b85d2e3939c428bfbfa2edce4bdcfd3be90
Cr-Commit-Position: refs/heads/master@{#298032}

Powered by Google App Engine
This is Rietveld 408576698