DescriptionRevert of [Android] Don't push deps when listing gtests. (patchset #1 id:1 of https://codereview.chromium.org/560133002/)
Reason for revert:
While we do want to only attempt to push once, this isn't the right way to do it. We should push _before_ attempting to list the tests, then be done with it.
Also, this breaks https://codereview.chromium.org/537063002/
Original issue's description:
> [Android] Don't push deps when listing gtests.
>
> PushDataDeps takes a long time even when all files are on the device
> because calculating the digests of all the files takes _much_ longer
> on a device than it does on a host.
>
> Skipping the push step during test listing -- where the data deps are
> unnecessary -- means that we don't try to push files twice in each
> gtest run, so we skip all of the device-side MD5 calculations that
> would happen in the second run.
>
> BUG=400440
>
> Committed: https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad
> Cr-Commit-Position: refs/heads/master@{#294667}
TBR=starodub@chromium.org,cjhopman@chromium.org,klundberg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400440
Committed: https://crrev.com/fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5
Cr-Commit-Position: refs/heads/master@{#297948}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|