Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 627553002: Revert of [Android] Don't push deps when listing gtests. (Closed)

Created:
6 years, 2 months ago by jbudorick
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Don't push deps when listing gtests. (patchset #1 id:1 of https://codereview.chromium.org/560133002/) Reason for revert: While we do want to only attempt to push once, this isn't the right way to do it. We should push _before_ attempting to list the tests, then be done with it. Also, this breaks https://codereview.chromium.org/537063002/ Original issue's description: > [Android] Don't push deps when listing gtests. > > PushDataDeps takes a long time even when all files are on the device > because calculating the digests of all the files takes _much_ longer > on a device than it does on a host. > > Skipping the push step during test listing -- where the data deps are > unnecessary -- means that we don't try to push files twice in each > gtest run, so we skip all of the device-side MD5 calculations that > would happen in the second run. > > BUG=400440 > > Committed: https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad > Cr-Commit-Position: refs/heads/master@{#294667} TBR=starodub@chromium.org,cjhopman@chromium.org,klundberg@chromium.org NOTREECHECKS=true NOTRY=true BUG=400440 Committed: https://crrev.com/fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5 Cr-Commit-Position: refs/heads/master@{#297948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/android/pylib/gtest/setup.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Don't push deps when listing gtests.
6 years, 2 months ago (2014-10-02 23:31:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627553002/1
6 years, 2 months ago (2014-10-02 23:32:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b88f99e10b7bb7ca864f32646c79ad9a00f27b9c
6 years, 2 months ago (2014-10-02 23:33:47 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:36:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc3ea0426cee341318cdc8d3f9ebb729e1dd64c5
Cr-Commit-Position: refs/heads/master@{#297948}

Powered by Google App Engine
This is Rietveld 408576698