Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 62753002: [NaCl SDK] Set PEPPER_DIR properly when building naclports. (Closed)

Created:
7 years, 1 month ago by binji
Modified:
7 years, 1 month ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Set PEPPER_DIR properly when building naclports. This should be "pepper_NN", but was coming through as a path. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
7 years, 1 month ago (2013-11-06 19:01:02 UTC) #1
Sam Clegg
Oops. Sorry about that. LGTM.
7 years, 1 month ago (2013-11-06 19:17:25 UTC) #2
binji
7 years, 1 month ago (2013-11-06 19:19:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r233322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698