Support fullscreen video for content shell

Support fullscreen video for content shell

Content shell doesn't support fullscreen video currently, this change fixes that issue.

Committed: https://crrev.com/c0eda62902b7557007ffc11659b94018f5e54faf
Cr-Commit-Position: refs/heads/master@{#297945}

[qinmin, 2014-10-02 21:39:36]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2014-10-02 21:39:37]

PTAL

[Ted C, 2014-10-02 21:52:45]

https://codereview.chromium.org/627513002/diff/1/content/shell/android/java/s...
File content/shell/android/java/src/org/chromium/content_shell/Shell.java
(right):

https://codereview.chromium.org/627513002/diff/1/content/shell/android/java/s...
content/shell/android/java/src/org/chromium/content_shell/Shell.java:266:
mWebContents.wasResized();
Why is this necessary?

Could we just do:
mUrlTextView.setVisibility(enterFullscreen ? GONE : VISIBLE);

That should trigger a resize on the content view, which I think is more correct
and avoids adding the wasResized function which already exists on
ContentViewCore, and I think shouldn't be added to WebContentsAndroid.

[qinmin, 2014-10-02 22:44:30]

https://codereview.chromium.org/627513002/diff/1/content/shell/android/java/s...
File content/shell/android/java/src/org/chromium/content_shell/Shell.java
(right):

https://codereview.chromium.org/627513002/diff/1/content/shell/android/java/s...
content/shell/android/java/src/org/chromium/content_shell/Shell.java:266:
mWebContents.wasResized();
Done. Set the whole toolbar's visibility to false when we enter fullscreen,
setting textview alone will still show the navigation buttons.

On 2014/10/02 21:52:45, Ted C wrote:
> Why is this necessary?
> 
> Could we just do:
> mUrlTextView.setVisibility(enterFullscreen ? GONE : VISIBLE);
> 
> That should trigger a resize on the content view, which I think is more
correct
> and avoids adding the wasResized function which already exists on
> ContentViewCore, and I think shouldn't be added to WebContentsAndroid.

[Ted C, 2014-10-02 22:47:48]

lgtm

[qinmin, 2014-10-02 22:48:43]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-10-02 22:51:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/627513002/20001

[commit-bot: I haz the power, 2014-10-02 23:24:30]

Committed patchset #2 (id:20001) as 89c883f6d386481e35fb423f9817233ea6a7e05b

[commit-bot: I haz the power, 2014-10-02 23:25:07]

Patchset 2 (id:??) landed as
https://crrev.com/c0eda62902b7557007ffc11659b94018f5e54faf
Cr-Commit-Position: refs/heads/master@{#297945}