Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 627473002: Handle getMemoryBase returning NULL in WriteTask. (Closed)

Created:
6 years, 2 months ago by bungeman-skia
Modified:
6 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Handle getMemoryBase returning NULL in WriteTask. DM::WriteTask::fData was changed from a data to a stream in "SkData to SkStreamAsset to avoid unneeded copying" https://skia.googlesource.com/skia/+/a4c6094177ebde18c706cbcfbd2013d0a088e0ee However, DM::WriteTask::draw was not updated to handle this, resulting in segfaults when trying to write out PDF files. Committed: https://skia.googlesource.com/skia/+/d51ce44d18cb28df568f817b05478d24ef21c1a7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M dm/DMWriteTask.cpp View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bungeman-skia
6 years, 2 months ago (2014-10-02 19:48:59 UTC) #2
mtklein
https://codereview.chromium.org/627473002/diff/1/dm/DMWriteTask.cpp File dm/DMWriteTask.cpp (right): https://codereview.chromium.org/627473002/diff/1/dm/DMWriteTask.cpp#newcode85 dm/DMWriteTask.cpp:85: if (stream->getMemoryBase()) { Let's skip the if and just ...
6 years, 2 months ago (2014-10-02 19:54:59 UTC) #3
bungeman-skia
https://codereview.chromium.org/627473002/diff/1/dm/DMWriteTask.cpp File dm/DMWriteTask.cpp (right): https://codereview.chromium.org/627473002/diff/1/dm/DMWriteTask.cpp#newcode85 dm/DMWriteTask.cpp:85: if (stream->getMemoryBase()) { On 2014/10/02 19:54:59, mtklein wrote: > ...
6 years, 2 months ago (2014-10-02 20:00:11 UTC) #4
mtklein
lgtm
6 years, 2 months ago (2014-10-02 20:03:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627473002/20001
6 years, 2 months ago (2014-10-02 20:04:48 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:39:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as d51ce44d18cb28df568f817b05478d24ef21c1a7

Powered by Google App Engine
This is Rietveld 408576698