Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 627423002: Replacing the OVERRIDE with override in chrome/installer (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in chrome/installer This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/31cd14fb3ead93e6d9fa748f6ec42d25e3edf8ff Cr-Commit-Position: refs/heads/master@{#298511}

Patch Set 1 #

Patch Set 2 : Patch is rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -192 lines) Patch
M chrome/installer/setup/archive_patch_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/callback_work_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.h View 1 chunk +19 lines, -19 lines 0 comments Download
M chrome/installer/util/chrome_app_host_operations.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/installer/util/chrome_browser_sxs_operations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 1 chunk +19 lines, -19 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/installer/util/delete_reg_key_work_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/firewall_manager_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +22 lines, -22 lines 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/install_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_validator.h View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/installer/util/legacy_firewall_manager_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/non_updating_app_registration_data.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/updating_app_registration_data.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 09:23:44 UTC) #2
MRV
On 2014/10/06 09:23:44, MRV wrote: > PTAL Dear Mr. Sky PTAL
6 years, 2 months ago (2014-10-06 16:14:37 UTC) #3
MRV
On 2014/10/06 16:14:37, MRV wrote: > On 2014/10/06 09:23:44, MRV wrote: > > PTAL > ...
6 years, 2 months ago (2014-10-07 03:39:02 UTC) #4
sky
sky->grt
6 years, 2 months ago (2014-10-07 15:21:42 UTC) #6
grt (UTC plus 2)
lgtm, although please remove mention of FINAL->final since there are no occurrences of this substitution. ...
6 years, 2 months ago (2014-10-07 15:49:58 UTC) #7
MRV
On 2014/10/07 15:49:58, grt wrote: > lgtm, although please remove mention of FINAL->final since there ...
6 years, 2 months ago (2014-10-07 15:57:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627423002/20001
6 years, 2 months ago (2014-10-07 15:59:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 534cb3421d478091cfc256d7f485302ec3ee6ab0
6 years, 2 months ago (2014-10-07 17:13:29 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 17:14:09 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31cd14fb3ead93e6d9fa748f6ec42d25e3edf8ff
Cr-Commit-Position: refs/heads/master@{#298511}

Powered by Google App Engine
This is Rietveld 408576698