[Devtools] Do not switch tabs by default when adding a tab.

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1154 matching lines @@
      * @param {string} id
      * @param {string} tabTitle
      * @param {!WebInspector.View} view
      * @param {string=} tabTooltip
      * @param {boolean=} userGesture
      * @param {boolean=} isCloseable
      */
     appendTab: function(id, tabTitle, view, tabTooltip, userGesture, isCloseable)
     {
         WebInspector.TabbedPane.prototype.appendTab.call(this, id, tabTitle, view, tabTooltip);
-        if (this._lastUserSelectedTabId !== this.selectedTabId)
+        if (this._lastUserSelectedTabId && this._lastUserSelectedTabId !== this.selectedTabId)

[pfeldman, 2014/10/06 04:56:14]

Is (was) this showing all the tabs as they were added? I wonder if we should
turn the control flow the other way around so that this details view was
listening to the timeline selection and was updating itself. That way it can
manage the tab selection properly.

The way it is now is because this details view was created out of the popover
that used to show upon timeline hover. Hence the suboptimal way of living.

@pdr: you don't have to do this, we can arrange this for you!

             this.selectTab(id);
     },
 
     _tabSelected: function(event)
     {
         if (!event.data.isUserGesture)
             return;
 
         this._lastUserSelectedTabId = event.data.tabId;
     },
@@ skipping 270 matching lines @@
 
 WebInspector.TimelinePanelFactory.prototype = {
     /**
      * @return {!WebInspector.Panel}
      */
     createPanel: function()
     {
         return WebInspector.TimelinePanel._instance();
     }
 }