Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 627413002: [Devtools] Do not switch tabs by default when adding a tab. (Closed)

Created:
6 years, 2 months ago by pdr.
Modified:
6 years, 2 months ago
Reviewers:
caseq, yurys, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[Devtools] Do not switch tabs by default when adding a tab. If the user has not selected a default tab, TimelineDetailsView's _lastUserSelectedTabId will be undefined which will cause appendTab to select the last added tab by default. This patch changes this behavior to not select the most recently added tab. This can be seen in the paint profiler where the paint tab takes precedence over the details tab. With this patch, the details tab is shown by default. TEST=manual. By default the paint tab is not selected on the timeline. BUG=410701

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (2 generated)
pdr.
6 years, 2 months ago (2014-10-06 04:28:51 UTC) #2
pfeldman
6 years, 2 months ago (2014-10-06 04:56:15 UTC) #4
https://codereview.chromium.org/627413002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TimelinePanel.js (right):

https://codereview.chromium.org/627413002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TimelinePanel.js:1175: if
(this._lastUserSelectedTabId && this._lastUserSelectedTabId !==
this.selectedTabId)
Is (was) this showing all the tabs as they were added? I wonder if we should
turn the control flow the other way around so that this details view was
listening to the timeline selection and was updating itself. That way it can
manage the tab selection properly.

The way it is now is because this details view was created out of the popover
that used to show upon timeline hover. Hence the suboptimal way of living.

@pdr: you don't have to do this, we can arrange this for you!

Powered by Google App Engine
This is Rietveld 408576698