Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 627273004: Don’t use using directives (“using namespace”) in tools (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Don’t use using directives (“using namespace”) in tools. The contents of tools are moved into the namespace crashpad::(anonymous namespace). https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/40602fab1f75d138c1a1d0a3c155351c964473dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M tools/catch_exception_tool.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M tools/exception_port_tool.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M tools/on_demand_service_tool.mm View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
Also, https://codereview.chromium.org/635883002/.
6 years, 2 months ago (2014-10-07 17:48:06 UTC) #2
Robert Sesek
I always had a preference for not putting an executable's code in a namespace, but ...
6 years, 2 months ago (2014-10-07 21:21:31 UTC) #3
Mark Mentovai
I know what you mean, but it sucks to have to write crashpad:: on every ...
6 years, 2 months ago (2014-10-07 21:25:53 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-07 21:30:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40602fab1f75d138c1a1d0a3c155351c964473dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698